Fix datasample to support k=0 empty array returns - #474
Merged
Conversation
pr0m1th3as
added a commit
that referenced
this pull request
Sep 8, 2026
…ts (#474). The preallocation for weighted sampling without replacement is a column, as it already is with replacement. Two tests cover k = 0 with weights, one per replacement mode. The four error tests for K match the full message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MATLAB, calling
datasample(data, 0)returns an empty array that preserves the non-sampled dimensions of the input data (e.g.,datasample(zeros(0,3), 0)returns a0x3array). In Octave, passingk=0throws a validation error:k must be a positive integer scalar. So this is fixed now via this pr.