Add the ten poka-yoke specialist skills - #2808
Open
rainmanjam wants to merge 3 commits into
Open
Conversation
The merged poka-yoke skill is the router. These are the ten modes it routes to, each self-contained with only the reference files and scripts its own SKILL.md names. Derived from the upstream plugin rather than hand-copied, so a refresh is a re-run. Verified: no path escapes its skill folder, every bundled path resolves, each frontmatter name matches its directory, and validate-skills.mjs passes on all 424.
github-actions
Bot
added
new-submission
Contributor
🔒 PR Risk Scan ResultsScanned 30 changed file(s).
|
Contributor
|
🟡 Contributor Reputation Check: MEDIUM risk
Maintainers: please review this contributor before merging. |
github-actions
Bot
added
the
needs-review:MEDIUM
Contributor
🔍 Vally Lint Results✅ All checks passed
Summary
Full linter output |
Four regex alternation stems and one hyphenation, all corrected upstream and re-derived. Verified locally with codespell and validate-skills before pushing rather than waiting for another CI round trip.
The merged poka-yoke skill describes its modes but never named them as installable skills, so a reader had no way to discover poka-yoke-audit and the rest. Adds a table naming all ten, the llm/agent-guardrails distinction, and a note that they compose. This makes the PR contain all eleven skills: the router plus the ten it routes to.
Contributor
|
Having a review of these skills, they are overly wordy for what they are trying to achieve. This can be detrimental to the performance of the agent. The original contribution from #2792 was also a bit on the wordy side, but given that it was a more generalist skill, that can be acceptable. Additionally, the skills rely heavily on Claude design patterns, suggesting that they are lifted straight from a Claude environment. For example, one of the skills relies on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second submission, following #2792 which added
poka-yoke— the router. This adds the tenmodes it routes to, and updates the router to name them.
poka-yoke-designpoka-yoke-auditpoka-yoke-retropoka-yoke-guardrailspoka-yoke-agent-guardrailspoka-yoke-authzpoka-yoke-datapoka-yoke-opspoka-yoke-llmpoka-yoke-uxThe router is updated too. As merged it described its modes but never named them as
installable skills, so a reader had no way to discover
poka-yoke-auditand the rest. It nowcarries a table of all ten, the
llm/agent-guardrailsdistinction, and a note that theycompose — an incident involving a bad migration is
poka-yoke-retrofor the analysis andpoka-yoke-opsfor the device.How they were built
Derived from the upstream plugin by a script rather than hand-copied, so a later refresh is a
re-run. Upstream shares one
references/andscripts/tree across all skills; your skillsare self-contained folders, so each got a copy of exactly the files its own
SKILL.mdnames — no more. Four need no bundled files at all.
Verified before pushing
node eng/validate-skills.mjspoka-yoke-audit's frontmatter name → named in the output, exit 1; restored → exit 0codespellon all eleven../escapesdocs/README.skills.mdeng/update-readme.mjsTwo codespell failures were fixed upstream at source rather than patched here, so the
plugin and these skills cannot drift: four regex alternation stems that read as typos to a
spell checker (
coalesc,doesn',(mis)?usetwice) and onepre-selected→preselected.I found the second by running codespell locally rather than waiting for another CI round trip.
On scope
Ten entries from one author is a lot to land at once. Happy to split this into separate PRs,
trim to the most broadly useful three or four (
design,audit,retro,guardrails), ordrop it if the router alone is the right footprint. Say the word and I will restructure.
Upstream: https://github.com/rainmanjam/poka-yoke (v0.2.0)