fix: reset skipped-nodes stack on getValue entry to prevent slice overflow panic [#4818] - #4819
Open
waterWang wants to merge 2 commits into
Open
fix: reset skipped-nodes stack on getValue entry to prevent slice overflow panic [#4818]#4819waterWang wants to merge 2 commits into
waterWang wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4819 +/- ##
==========================================
- Coverage 99.21% 98.32% -0.89%
==========================================
Files 42 48 +6
Lines 3182 3173 -9
==========================================
- Hits 3157 3120 -37
- Misses 17 43 +26
- Partials 8 10 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4818
Root cause
With
HandleMethodNotAllowed = true,handleHTTPRequestcallsgetValueonce per method tree in the
HandleMethodNotAllowedloop, reusing thesame
c.skippedNodesstack from the pooled Context.getValuepushesentries onto the stack via a raw reslice (
[:index+1]) that cannot growpast
engine.maxSections. Without resetting the stack on entry, residuefrom a previous tree accumulates until the next reslice exceeds capacity
and panics with "slice bounds out of range".
Fix
Reset
*skippedNodes = (*skippedNodes)[:0]at the top ofgetValuesoevery call starts with an empty stack. This is the single point that
covers all callers, including the
HandleMethodNotAllowedloop.Tests
TestIssue4818_skippedNodesOverflow_Panic: original repro from theissue — POST to a route that causes skippedNodes residue to exceed
maxSectionscapacity. Confirms no panic and 404 (correct).TestIssue4818_MethodNotAllowedStillWorks: PATCH a path that onlyhas a GET route, confirming the
HandleMethodNotAllowedloop stillproduces a correct 405 with Allow header.
TestIssue4818_MethodNotAllowedManyTrees: stress test with 9 methodtrees targeting a single GET-only path, verifying no overflow.