Make REDASH_DISABLE_PUBLIC_URLS the source of truth over stale org settings

[ekanshul]

What type of PR is this?

• Bug Fix

Description

Fixes #7630.

REDASH_DISABLE_PUBLIC_URLS=true has no effect when the organizations.settings JSON already contains a disable_public_urls key, because Organization.get_setting() prefers the stored value.

How the stale value gets into the DB in the first place: disable_public_urls is not editable anywhere in the admin UI, but the General Settings form posts back every value it received from GET /api/settings/organization (see useOrganizationSettings.jsx — OrgSettings.save(currentValues)). So the first time an admin hits Save, the then-current env default is silently persisted, and from that point on the environment variable is dead for this key.

The fix: when REDASH_DISABLE_PUBLIC_URLS is explicitly set in the environment, it takes precedence over any value stored in the organizations table (Organization.get_setting() skips the stored value). This neutralizes stale rows written by older versions without any DB surgery, and matches the issue's expectation that a setting not editable via the UI follows the environment variable.

When the variable is not set, nothing changes: stored values keep working, POST /api/settings/organization persists them as before, and the audit trail is untouched. In particular the Cypress sharing/embed specs, which toggle disable_public_urls through the API at runtime (cy.updateOrgSettings({ disable_public_urls: ... })), are unaffected since CI doesn't set the variable.

The override set is computed in redash/settings/organization.py (env_overrides) and is easy to extend to other env-only settings if the need arises.

How is this tested?

• Unit tests (pytest, jest)

New tests in tests/handlers/test_settings.py:

• test_env_override_wins_over_stored_value — with the override active, a stored disable_public_urls: true no longer shadows the env value.
• test_stored_value_applies_without_env_override — without the env var, posting the setting through the API still works (guards the Cypress flows).

pytest tests/handlers/test_settings.py tests/handlers/test_dashboards.py passes locally; ruff check and black --check are clean.

Related Tickets & Documents

#7630

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

N/A (backend only; the Share button simply follows the env var again)

[greptile-apps]

Greptile Summary

The PR makes an explicitly configured REDASH_DISABLE_PUBLIC_URLS value authoritative over stale organization settings while preserving stored-value behavior when the variable is absent.

• Adds a startup-derived set of organization settings overridden by environment configuration.
• Updates Organization.get_setting() to bypass stored values for those keys.
• Adds tests for both environment-controlled and database-controlled behavior.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
redash/models/organizations.py	Updates setting lookup precedence so explicitly environment-controlled keys bypass stale organization values.
redash/settings/organization.py	Defines the environment-controlled organization-setting keys based on explicitly present environment variables.
tests/handlers/test_settings.py	Covers environment precedence and preservation of API-persisted behavior when no override is configured.

_{Reviews (2): Last reviewed commit: "Make explicitly-set REDASH_DISABLE_PUBLI..." | Re-trigger Greptile}

[greptile-apps]

Runtime test toggles are discarded

When the sharing Cypress scenarios call updateOrgSettings to enable or disable public URLs, this branch discards the requested value and get_setting ignores any stored value, causing scenarios to run with the unchanged environment setting and fail their state-dependent assertions.

[ekanshul]

Good catch — reworked. The env var now takes precedence only when it is explicitly set in the environment; when unset (as in CI), stored values and the settings endpoint behave exactly as before, so the Cypress sharing/embed specs that call updateOrgSettings({ disable_public_urls: ... }) are unaffected.

[greptile-apps]

Audit records ignored setting changes

When an administrator saves General Settings, this branch excludes disable_public_urls from persistence and previous_values, but the later audit event records the unfiltered request as new_values, causing the audit trail to report a settings change that was never applied.

[ekanshul]

Resolved by the rework: the settings endpoint's persistence and audit behavior is back to unchanged — the override now only affects read precedence in Organization.get_setting(), and only when the environment variable is explicitly set.