Add an extra SortBot and make SortBot routine the default - #903
Add an extra SortBot and make SortBot routine the default#903AnaIPereira wants to merge 2 commits into
Conversation
AnaIPereira
commented
Sep 8, 2026
AnaIPereira
commented
- Add an extra SortBot
- Create a function for the number of SortBots: GetNumberOfSortBots
- Delete MasterMerge and always use SortBotMasterMerge, making the SortBot routine mandatory; 0 and 1 threads also go in this routine, using the logic at the bottom of the tree in the merging process of the SortBots.
- In the process of merging the terms in SortBots, the new extra SortBot does the last merging (instead of the master) and now the master only does the writing in the end; - Create function GetNumberOfSortBots that returns the number of SortBots given the number of workers as input: in any place where the number of SortBots is needed in the code, it is called by this local function.
- remove conditional logic #ifdefWITHSORTBOT to make sortbots mandatory; - Delete MasterMerge function and replace it with the usage of SortBotMasterMerge; The multi-thread and single-thread processes now use SortBotMasterMerge, in particular the end-of-tree logic of merging the SortBots for the single thread case.
|
Presumably #902 resolves the 32-bit runner issues. This change affects only a sub-set of the form-bench tests, those in which the master spends a roughly equal amount of time merging terms and writing output. This appears to mean, "using On my usual system, this means: speedup w.r.t tform-master -w12
Since now all tform thread counts >= 1 use the same merging routine, we could remove the I also have something in the works for compression of scratch files: this change also will mean that scratch compression runs in parallel to term merging for tform. |
2 participants
