refactor(monit): drop retired v1 rule clients, add public v2 rule APIs - #74
Merged
Conversation
Synced openapi/ from flashduty-docs main and regenerated: - Remove WriteCreate/WriteUpdate/ReadInfo/ReadCounterNode/ReadDstypes (endpoints retired upstream in monit-webapi / removed from the public registry in fc-pgy). - Add ReadInfoV2/WriteCreateV2/WriteUpdateV2 for the new public /monit/rule/v2/* contract. - The applications.go and schedules.go additions come from the spec sync pulling in other already-public endpoints (RUM remote-config and schedule APIs), not from manual edits. Note: this is a breaking change for SDK consumers still calling the removed v1 methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更
vendored OpenAPI 已同步 flashduty-docs（配套 PR: flashcatcloud/flashduty-docs#379）并重新
go generate：WriteCreate/WriteUpdate/ReadInfo/ReadCounterNode/ReadDstypes—— 对应端点已在 monit-webapi 退役（flashcatcloud/monit-webapi#118）并从网关公开注册表移除（flashcatcloud/fc-pgy#957）/monit/rule/v2/info、/monit/rule/v2/create、/monit/rule/v2/update的公开客户端方法（v2 已在网关转为 app_key 可调用）applications.go/schedules.go的新增方法是 spec 同步顺带带入的其他已公布接口（RUM remote-config、排班相关），非手工修改仍在调用被删 v1 方法的 SDK 使用方升级后会编译失败，发版时需要版本说明。
验证
go build ./...、go test ./...通过。