[2.x] pref(subscriptions): Separate subscription button and dropdown option labels - #5026
Open
thatsgolden wants to merge 1 commit into
Open
[2.x] pref(subscriptions): Separate subscription button and dropdown option labels#5026thatsgolden wants to merge 1 commit into
thatsgolden wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected versions: based on 2.x at f194386 (Application::VERSION = 2.0.0-rc.8).
Pref
Changes proposed in this pull request:
The main subscription button represent states (Not Following, Following, or Ignoring), and a default action to Unfollow, while the dropdown options performs an action (Follow, Unfollow, or Unignore). Currently the same labels are also used for the main action button, which is difficult to i18n naturally in Chinese. So it is better to separate them.
I didn't change the labels of the dropdown options, in case the original wording is already appropriate in English.
Screenshot
Confirmed