fix: broken UI build path - #1703
Open
jescalada wants to merge 10 commits into
Open
Conversation
Fixes issue with UI being excluded from the built NPM package. Docker was unaffected
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
- Coverage 86.06% 86.05% -0.02%
==========================================
Files 101 101
Lines 5561 5571 +10
Branches 992 995 +3
==========================================
+ Hits 4786 4794 +8
Misses 526 526
- Partials 249 251 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Prevents "npm run build" from running twice in CI
Fixes windows build smoke test failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Originally brought up by @re-vlad on the roadmap call #1702
Fixes issue with UI being excluded from the built NPM package. Docker build was unaffected. This affects 2.0 and 2.1, so we'll have to get a patch out for 2.1.1 (or deprecate these two and ship the fix in 2.2):
Also adds a smoke test CI script to check that the UI is actually present and executable in the built package:
After
npm run buildonmainAfter
npm run buildwith these changesRelated Issue
Resolves #1704
Checklist
General
Documentation
Configuration
config.schema.json) was modified:npm run generate-config-types)npm run gen-schema-doc)Tests
npm test)npm run lintandnpm run format:check)npm run check-types)