Skip to content

Normalize CIF datablock names during import - #223

Merged
AndrewSazonov merged 2 commits into
developfrom
normalize-cif-datablock-names
Sep 14, 2026
Merged

AndrewSazonov merged 2 commits into
developfrom
normalize-cif-datablock-names

Conversation

@AndrewSazonov

Copy link
Copy Markdown
Member

Convert imported CIF datablock names to lowercase and remove unsupported characters while preserving letters, digits, hyphens, and underscores. Directly created structure and experiment names remain strictly validated.

@AndrewSazonov AndrewSazonov added the [scope] bug Bug report or fix (major.minor.PATCH) label Sep 14, 2026
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.40%. Comparing base (94970a9) to head (a275cf4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
+ Coverage    90.38%   90.40%   +0.01%     
===========================================
  Files          284      284              
  Lines        24789    24792       +3     
  Branches      2910     2910              
===========================================
+ Hits         22405    22412       +7     
+ Misses        1755     1754       -1     
+ Partials       629      626       -3     
Flag Coverage Δ
unittests 90.40% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easydiffraction/io/cif/parse.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndrewSazonov
AndrewSazonov merged commit c4ae7e8 into develop Sep 14, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant