Skip to content

Fix EasyList to accept a list of parameters #307

Description

@rozyczko

As noted in #306 (comment) we should be able to instantiate EasyList with a simple list/tuple of parameters.

E.g.

el = EasyList(Parameter('a', value=1.0), Parameter('b', value=2.0))

Currently, EasyList drops those kwargs, as EasyList overrides get_all_variables to only recurse into ModelBase items, not simple sequences and bare descriptors are dropped.

el.get_all_variables()   # []
el.get_fit_parameters()  # []

I am marking this as a bug since any sane person would expect a simple list to be accepted for fitting.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    [area] base classesChanges to or creation of new base classes[priority] highestUrgent. Needs attention ASAP[scope] bugBug report or fix (major.minor.PATCH)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions