Skip to content

In case of empty resource key use 'NOKEY' fallback - #448

Merged
devlead merged 2 commits into
devlead:developfrom
visma-mrange:mrange/Fallback_in_case_of_file_locking
Sep 2, 2026
Merged

In case of empty resource key use 'NOKEY' fallback#448
devlead merged 2 commits into
devlead:developfrom
visma-mrange:mrange/Fallback_in_case_of_file_locking

Conversation

@visma-mrange

Copy link
Copy Markdown

I am not satisfied with my proposal but I thought we could discuss the issue a bit. For some reason I consistently get file-locking issues when running. I don't use the parallel option.

It's always the same files and they are related to enviroment tags file.

For some reason it seems that we end up regenerating the same file in two different paths. I think a better solution would be to make sure the environment tags are grouped together.

I didn't figure out how to do it but perhaps you have some ideas:

Path to file that files for us:

contracting.works\test\README.md

The content of the README.md file:

---
summary: Resources for tag test
modifiedby: ARI
---

## Values

|                                                                                                 |
|-------------------------------------------------------------------------------------------------|
|  |

The content of the file that ends up with a random name. I removed our identifiers although I don't think they are sensitive

---
summary: test = 
modifiedby: ARI
---

## Resources

| | | |
|-|-|-|
| **Microsoft.ServiceBus** | | |
| [contracting-test](../<GUID>/TestDev/contracting-test) | [namespaces](../<GUID>/TestDev/contracting-test) | [northeurope](../<GUID>/TestDev/contracting-test) |
| | |
| **Microsoft.Sql** | | |
| [cw-db-elastic-test/test-client-test-cypress](../<GUID>/TestDev/cw-db-elastic-test/test-client-test-cypress) | [servers/databases](../<GUID>/TestDev/cw-db-elastic-test/test-client-test-cypress) | [northeurope](../<GUID>/TestDev/cw-db-elastic-test/test-client-test-cypress) |
| | |

I can do some more experiments later on grouping the files.

@visma-mrange

Copy link
Copy Markdown
Author

After debugging found the writer and the valueWriter got the same path because for some reason the resources key was empty string. In that case sets it to NOKEY now. Works on my machine.

@devlead devlead changed the title On IOException generate a randomized name In case of empty resource key use 'NOKEY' fallback Sep 2, 2026
….json

Replace the hand-rolled MockHttpClient switch and ARIServiceProviderFixture with the package ServiceProviderFixture and Routes.json, and cover empty tag values writing under NOKEY.
@devlead
devlead force-pushed the mrange/Fallback_in_case_of_file_locking branch from d4bb073 to e1a954c Compare September 2, 2026 20:52
@devlead
devlead merged commit 42a9ac1 into devlead:develop Sep 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants