Skip to content

fix(profile): persist pending social links on save - #6663

Open
rebelchris wants to merge 1 commit into
mainfrom
eng-2011-feedback-ux-issue-link-to-github-in-profile-details-does-not
Open

rebelchris wants to merge 1 commit into
mainfrom
eng-2011-feedback-ux-issue-link-to-github-in-profile-details-does-not

Conversation

@rebelchris

@rebelchris rebelchris commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Issue: https://linear.app/dailydev/issue/ENG-2011/feedback-ux-issue-link-to-github-in-profile-details-does-not-save-in

Summary:

  • Flush pending social link input before profile Save so pasted GitHub URLs are committed without requiring Add.
  • Preserve dirty social links while the full profile query resolves and omit untouched socialLinks before initialization to avoid accidental clears.
  • Surface profile update failures through inline socialLinks errors or fallback toasts instead of invisible field errors.
  • Add focused RTL coverage plus a Playwright regression for the reported Save-without-Add flow.

Key decisions:

  • The committed socialLinks array remains the form source of truth; pending input is only flushed on blur or submit.
  • Invalid pending text blocks Save and renders the existing field error UI.
  • Errors for fields absent from this settings page are routed to toasts.

Closes ENG-2011


Created by Huginn 🐦‍⬛

Preview domain

https://eng-2011-feedback-ux-issue-link.preview.app.daily.dev

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
daily-webapp Ready Ready Preview Sep 15, 2026 2:16pm UTC

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant