docs(#3542): add Go version consistency guidance to AGENTS.md - #3543
docs(#3542): add Go version consistency guidance to AGENTS.md#3543fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add a new "Go Version Consistency" section listing the seven files that must declare the same Go version (go.mod files, .tool-versions, Dockerfile, Dockerfile.dist) and reviewer guidance for detecting mismatches on Go version bump PRs. This enables the review agent to flag cross-file version inconsistencies that can cause build failures when GOTOOLCHAIN=local is set. Motivated by PR #3538 where go.mod was bumped to a different version than the Dockerfile base images. Complements #3360 (Renovate atomic updates) by providing review-time detection for manual bumps. Note: pre-commit hooks were not run. pre-commit could not complete (infrastructure failure fetching remote hook repos). The only configured hook (check-commit-message) checks commit messages, not file content. Closes #3542
|
🤖 Finished Review · ✅ Success · Started 3:28 PM UTC · Completed 3:40 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.88 |
|
Risk Assessment: low (1/5) DetailsDocs-only PR adding 18 lines of guidance to AGENTS.md by a known bot author, with a perfectly scoped linked issue and no security, CI, or dependency changes — minimal risk. |
ReviewFindingsMedium
Low
Next steps:
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| 5. `.tool-versions` (`golang X.Y.Z`) | ||
| 6. `Dockerfile` (`FROM golang:X.Y.Z@sha256:...`) | ||
| 7. `Dockerfile.dist` (`FROM go-toolset:X.Y.Z@sha256:...`) | ||
|
|
There was a problem hiding this comment.
[low] technical documentation accuracy
The Dockerfile.dist entry abbreviates the image as FROM go-toolset:X.Y.Z@sha256:... but the actual FROM line uses registry.access.redhat.com/ubi9/go-toolset:1.26.7@sha256:.... Dropping the ubi9/ path segment reduces greppability for reviewers checking version consistency. The Dockerfile entry abbreviating docker.io/library/golang to golang is standard Docker Hub convention and not misleading.
Suggested fix: Change item 7 to Dockerfile.dist (FROM ubi9/go-toolset:X.Y.Z@sha256:...) to preserve the distinguishing path component.
What:
Add a "Go Version Consistency" section to AGENTS.md listing the seven files that must declare the same Go version and reviewer guidance for detecting mismatches on version bump PRs.
Why:
PR #3538 bumped
go.modto a different Go version than the Dockerfile base images. The review agent approved the mismatch because AGENTS.md had no guidance about which files must stay in sync. This section enables the review agent (and human reviewers) to flag cross-file version inconsistencies that can cause build failures whenGOTOOLCHAIN=localis set.Complements #3360 (Renovate atomic updates) by providing review-time detection for manual bumps or partial Renovate PRs.
Tickets:
Closes #3542
Post-script verification
agent/3542-go-version-consistency-docs)09f8926f1779f7bee2d93ee6f29a8e0e56c05842..HEAD)