Skip to content

fix: Remove reference to deleted quick-build-args.conf - #3537

Open
dheerajodha wants to merge 1 commit into
conforma:mainfrom
dheerajodha:fix-build-args-in-release-script
Open

fix: Remove reference to deleted quick-build-args.conf#3537
dheerajodha wants to merge 1 commit into
conforma:mainfrom
dheerajodha:fix-build-args-in-release-script

Conversation

@dheerajodha

Copy link
Copy Markdown
Contributor

What:

Since PR #2478 removed the build args files, the release branch script should set both build args to empty string instead of referencing the no longer existing quick-build-args.conf.

Why:

So, we won't have to manually remove it anymore.

Tickets:

Ref: https://redhat.atlassian.net/browse/EC-2154

Since PR conforma#2478 removed the build args files, the release branch script
should set both build args to empty string instead of referencing the
no longer existing quick-build-args.conf.

Ref: https://redhat.atlassian.net/browse/EC-2154

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 3332a9b2-59e0-40d0-8548-3fb8a6b6fe7b

📥 Commits

Reviewing files that changed from the base of the PR and between af3fe00 and 73edccf.

📒 Files selected for processing (1)
  • hack/release-branch-pipeline-patch.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Release pipeline

Layer / File(s) Summary
Update build argument transformation
hack/release-branch-pipeline-patch.sh
The release pipeline transformation removes main-pre-merge-build-args.conf without replacing it with quick-build-args.conf.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 73edc

The release-branch script now clears both build argument values without referencing the deleted configuration file. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the removal of the obsolete quick-build-args.conf reference.
Description check ✅ Passed The description includes complete What, Why, and Tickets sections. It explains the change, its context, and links ticket EC-2154.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 3, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:02 AM UTC · Completed 11:14 AM UTC

Commit: ca5794c · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.63

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.46% <ø> (ø)
generative 12.27% <ø> (ø)
integration 23.59% <ø> (ø)
unit 72.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Sep 3, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: low (1/5)

Details

Minimal-risk single-file, 2-line fix in a release helper script that removes a stale reference to a deleted config file; no protected paths, no security sensitivity, no CI or dependency changes, and negligible git history churn.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Sep 3, 2026

@BohdanMar BohdanMar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge risk/low PR risk: low size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants