Simulator reported the host machine's pixel ratio instead of the simulated device's - #5728
Merged
Merged
Conversation
getDevicePixelRatio on JavaSE returned the host display's backing scale unconditionally. In the simulator that is the wrong machine: a loaded skin means the process is standing in for another device, and a 2x desktop showing a 3x phone skin reported 2. Anything laying out in the platform's logical units then came out two thirds of its size. The scale is now reported only when no skin is loaded, which is a real desktop application on this display and exactly what the API asks. With a skin it answers the "not reported" value, which the documented contract already defines: the caller derives the ratio from the density bucket, which describes the device being simulated rather than the machine simulating it -- and is what this call resolved to before the platform reported a scale at all. The decision sits in a package-private helper rather than inline, so it can be tested. JavaSEPort's constructor initialises a look and feel that needs a native library which is not present on every machine, and several existing tests in this module cannot run because of it; the part that was wrong here is the decision, and that needs no port. Verified by removing the check again: the skinned case then reports 2.0 where 0 is expected, which is the regression. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70c2db3cd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @Override | ||
| public float getDevicePixelRatio() { | ||
| return retinaScale > 0 ? (float) retinaScale : super.getDevicePixelRatio(); | ||
| return devicePixelRatioFor(isDesktop(), retinaScale, super.getDevicePixelRatio()); |
There was a problem hiding this comment.
When a device skin is loaded, this return now deliberately yields the notReported sentinel, but the method-level documentation immediately above still says a skin reports the host retinaScale, honors its overrides, and always matches the renderer. This directly contradicts both the implementation and the new helper documentation, so readers cannot reliably determine the JavaSE contract; revise or remove the obsolete skin-specific paragraphs together with this behavior change.
Useful? React with 👍 / 👎.
Collaborator
Author
|
Compared 12 screenshots: 12 matched. |
Collaborator
Author
|
Compared 151 screenshots: 151 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
Compared 181 screenshots: 181 matched. |
Collaborator
Author
|
Compared 160 screenshots: 160 matched. Benchmark Results
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 148 screenshots: 148 matched. Benchmark Results
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 144 screenshots: 144 matched. |
Collaborator
Author
|
Compared 143 screenshots: 143 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 149 screenshots: 149 matched. Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
Collaborator
Author
|
Compared 217 screenshots: 217 matched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is wrong
JavaSEPort.getDevicePixelRatio()returns the host display's backing scaleunconditionally. In the simulator that describes the wrong machine: a loaded
skin means the process is standing in for another device, so a 2x desktop
showing a 3x phone skin reports 2.
Anything that lays out in the platform's logical units is then two thirds of its
intended size. The method is new in #5686, so this is a regression introduced
there rather than long-standing behaviour.
The fix
Report the backing scale only when no skin is loaded — which is a real desktop
application on this display, and exactly what the API asks.
With a skin, answer the documented "not reported" value. That sends the caller
to the density bucket, which describes the device being simulated rather than
the machine simulating it, and is what this call resolved to before the platform
reported a scale at all.
Why the logic moved into a helper
JavaSEPort's constructor initialises a look and feel that needs a nativelibrary which is not present on every machine — several existing tests in this
module cannot run because of it. The part that was wrong is the decision, and a
decision needs no port, so it sits in a package-private
devicePixelRatioFor(desktop, hostScale, notReported)that the accessordelegates to.
Verification
JavaSEPortDevicePixelRatioTestpins three cases: a skinned simulator must notreport the host scale, a desktop application must, and a host reporting no scale
falls back to "not reported" rather than a ratio of zero.
Confirmed by removing the check again — the skinned case then reports
2.0where
0is expected, which is the regression. Restored, 3/3 pass.🤖 Generated with Claude Code