fix(chat): match the reply strip to the composer's surface - #1431
Merged
Conversation
The strip built its own glass — a 16dp blur tinted toward a grey lifted off the background at 0.72 alpha — while the field and the send-cash button directly beneath it use HazeMaterials.ultraThin over the background. On the emulator the strip's fill sampled (50, 50, 51) against the field's (28, 28, 29), so it read as a second, lighter surface rather than as part of the composer. Use the composer's material, its divider hairline in place of the white 8% one, and CodeTheme.shapes.medium in place of the local 14dp radius. The fill now samples (27, 27, 28). CodeTheme.shapes is Material 2's Shapes, so chat-ui needs the M2 artifact on its compile classpath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composer's reply strip built its own glass: a 16dp blur tinted toward
lerp(background, White, 0.18f)at 0.72 alpha, a white 8% hairline, and a local 14dp corner radius. The chat input and the send-cash button directly beneath it useHazeMaterials.ultraThin(containerColor = background),CodeTheme.colors.divider, andCodeTheme.shapes.medium. The strip sat on top of both, so the mismatch read as a second, lighter surface rather than part of the bar.Measured on
emulator-5554, same chat and same pending reply:(50, 50, 51)(28, 28, 29)(25, 25, 26)(27, 27, 28)(28, 28, 29)(25, 25, 26)The strip now takes the composer's material, hairline, and shape. The no-haze fallback moves from a near-opaque copy of the old tint to
Color.White.copy(alpha = 0.1f), the flat stand-inCancelEditButtonalready uses.CodeTheme.shapesis Material 2'sShapes, which was not onchat-ui's compile classpath, so the module gainsimplementation(libs.compose.material).