fix(chat): stop reporting an empty transcript to Bugsnag - #1430
Merged
Conversation
github-actions
Bot
added
area: network
Opening a chat nobody has written in yet returns GetMessages NOT_FOUND, which InternalChatMessagingRepository hands to ErrorUtils.handleError. Every reporter sees it, so a normal empty conversation opens a Bugsnag error group — 72 events from one user on 2026.8.5. The notifiability tiers had no way to say "expected, don't report": a plain CodeServerError is still sent, just downgraded to INFO. Add UnreportedError as a third tier below that. Errors marked with it are still logged, so they stay in the trace attached to a real report, but ErrorUtils does not hand them to the reporters. GetMessagesError.NotFound is the first user; the sibling NotFound results are candidates but are left alone here.
bmc08gt
force-pushed
the
fix/chat-empty-transcript-report-noise
branch
from
September 8, 2026 18:01
8fd4040 to
1b0bdc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a chat nobody has written in yet returns
GetMessagesNOT_FOUND.ChatMessagingServiceturns that intoGetMessagesError.NotFound, andInternalChatMessagingRepositorypipes every failure throughErrorUtils.handleError, so a normal empty conversation opens a Bugsnag error group. One group has 72 events from a single user on 2026.8.5. Its breadcrumbs show the shape plainly: navigate intoConversation, four successful RPCs, then the error — twice in eight seconds, on two different chats.NotFoundwas already excluded fromNotifiableError, but that only downgrades severity to INFO. The event is still sent, so it still opens a group. There was no tier for "expected result, don't report at all".Change
UnreportedErrorinlibs/logging— a third tier belowNotifiableError(reported, WARNING, drives the Slack filter) and a plainCodeServerError(reported, INFO, recorded for reference).ErrorUtils.shouldReport(throwable, cause)gates the reporter loop and folds in the existingignoredErrorscheck. Marked errors still reachTimber.e, so they stay in the App Logs tail attached to real reports; they just never reach a reporter.GetMessagesError.NotFoundimplements it.Scope
The sibling results are the same shape of noise —
GetMessageError.NotFound,GetDmChatFeedError.NotFound, and the variousDeniedcases. I left them alone rather than widen this on my own read; say the word and they can follow.This stops new events. The 72 already filed need the group resolved in Bugsnag once a build carrying this ships.