feat(chat): hint "Reply" while the composer is replying - #1429
Merged
Conversation
The composer's hint read "Message" in every state, so a reply that was started from a swipe or a long press looked like a new message once the keyboard covered the reply strip. The hint now reads the same `state.replyingTo` that gates the strip, so both appear and clear on one state change. Both hints move to string resources in `:apps:flipcash:core` alongside the other chat strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composer hint read "Message" in every state. A reply starts from a swipe or a long press, and once the keyboard comes up over the reply strip there was nothing left in the composer saying the next send would be a reply.
The hint now reads the same
state.replyingTothat gates the reply strip, so the placeholder and the strip appear and clear on one state change.Both hints move to string resources (
hint_chatMessage,hint_chatReply) in:apps:flipcash:core, next to the other chat strings. They resolve through the feature's ownRbecauseandroid.nonTransitiveRClass=false, the same way the existingR.string.action_cancelEditreference in this file does.