docs(fee): document effective base-fee floor vs minBaseFee - #372
Open
kutluhaneth46 wants to merge 1 commit into
Open
docs(fee): document effective base-fee floor vs minBaseFee#372kutluhaneth46 wants to merge 1 commit into
kutluhaneth46 wants to merge 1 commit into
Conversation
Pin the empty-block truncation floor (kRate=1250 → 7 wei) with a unit test and record the max(minBaseFee, 10000/kRate) interaction in ADR-0004. Leaves ProtocolConfig requires alone so historical testnet genesis still regenerates. Addresses circlefin#367.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max(minBaseFee, 10000/kRate)in ADR-0004 (decrease-path integer truncation).assets/testnet/config.jsonfee params are historical vs live testnet.kRate=1250resting at 7 wei.Deliberately does not add a
ProtocolConfigrequire(minBaseFee * kRate >= 10000)— that would break regenerating historical testnet genesis (kRate: 25,minBaseFee: 1). Happy to follow up if maintainers want that guard only onupdateFeeParams.Addresses #367.
Test plan
arc_calc_next_block_base_feematches issue Fee curve: effective base-fee floor is max(minBaseFee, 10000/kRate); testnet ran 6M blocks at 7 wei against a declared floor of 1 #367 table (block 1/2/5/10/100/1000 → 7)cargo test -p arc-execution-config empty_blocks_rest_at_truncation_floor