Skip to content

fix(artifact): emit valid range headers #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamjr15 merged 2 commits into from
Aug 25, 2026
Merged

fix(artifact): emit valid range headers #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6ef85b
fix(artifact): emit valid range headers
iamjr15 Aug 25, 2026
2cb4d56
ci: build Worker budget prerequisites
iamjr15 Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/static-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,15 @@ jobs:
if: needs.changes.outputs.root_code == 'true'
run: pnpm typecheck:scripts

- name: Build Worker performance-budget prerequisites
run: |
pnpm exec turbo run build \
--filter=@cheatcode/agent-worker \
--filter=@cheatcode/artifact-worker \
--filter=@cheatcode/gateway-worker \
--filter=@cheatcode/preview-proxy \
--filter=@cheatcode/webhooks-worker

- name: Check Worker performance budgets
run: pnpm worker:performance-budgets

Expand Down
8 changes: 5 additions & 3 deletions apps/artifact-worker/src/output-routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,14 @@ function outputHeaders(object: R2Object, filename: string, mimeType: string): He
}

function normalizedRange(range: R2Range, size: number): { length: number; offset: number } {
if ("suffix" in range) {
if ("suffix" in range && typeof range.suffix === "number") {
const length = Math.min(range.suffix, size);
return { length, offset: size - length };
}
const offset = range.offset ?? 0;
return { length: Math.min(range.length ?? size - offset, size - offset), offset };
const offset = "offset" in range && typeof range.offset === "number" ? range.offset : 0;
const requestedLength =
"length" in range && typeof range.length === "number" ? range.length : size - offset;
return { length: Math.min(requestedLength, size - offset), offset };
}

function setPrivateDownloadHeaders(headers: Headers): void {
Expand Down