fix: stream generated media with byte ranges - #278
Merged
Conversation
Forward single-range requests to R2 with correct partial-content metadata. Preserve cross-origin resource policy only for signed artifact streams so native media previews load and seek reliably.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture
The signed gateway capability remains the only public artifact URL. The gateway forwards the request headers over its service binding; the agent worker validates the capability and ownership, asks R2 for the requested range, then streams that body with
206,Content-Range,Content-Length,Accept-Ranges, and ETag metadata.Decisions
cross-originonly on signed artifact streamstrycheatcode.comto rendergateway.trycheatcode.commedia without weakening every API responseVerification
pnpm lintpnpm typecheckpnpm turbo build --forcepnpm deadcodepnpm architecture:checkpnpm turbo skills:build206and only the requested bytes