fix: harden app-builder verification and production builds - #261
Merged
Conversation
Make browser actions strict and method-specific. Keep automation failures from mutating app architecture. Ship one buildable Next scaffold and verify it in every new snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture
The sandbox image now owns the entire Next scaffold, including TypeScript and PostCSS configuration. AgentRun customizes only the request-specific page. Runtime dependencies remain an immutable linked tree, and package resolution follows that normal
node_modulesboundary for previews, typechecking, and builds.Browser tool schemas describe complete action variants at the model boundary. Runtime validation remains authoritative for every provider, while supported providers also receive strict function schemas.
Decisions Made
Edge Cases Handled
How to Review
packages/agent-core/src/tools/browser/actions.tsfor the model-facing action contract.infra/containers/sandbox/app-templates/next/and the scaffold writer for the single template boundary..github/workflows/build-snapshot.ymlfor the image acceptance test.Verification
pnpm lintpnpm typecheckpnpm turbo build --forcepnpm deadcodepnpm architecture:checkpnpm turbo skills:buildNo Linear issue or plan document is associated with this production defect investigation.