Wait for the renderer goroutine before Resetting its ticker - #1781
Open
AshSgDe29071999 wants to merge 1 commit into
Open
Wait for the renderer goroutine before Resetting its ticker#1781AshSgDe29071999 wants to merge 1 commit into
AshSgDe29071999 wants to merge 1 commit into
Conversation
stopRenderer returned as soon as it signaled done, so the old goroutine's ticker.Stop could run after startRenderer's ticker.Reset. After tea.Exec the program kept running but the terminal froze. Fixes charmbracelet#1778
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stopRenderersignaled the render loop and returned immediately. The old goroutine'sticker.Stop()could run afterstartRenderer'sticker.Reset(), which permanently stops the ticker.After
tea.Exec/ReleaseTerminal/RestoreTerminal, the program kept processing messages while the terminal froze.stopRenderernow waits for the render goroutine to exit beforestartRendererresets the ticker.Fixes #1778