Skip to content

docker: reuse tested images for artifact uploads - #177

Merged
dhalperi merged 1 commit into
masterfrom
reuse-tested-artifacts-for-release
Aug 27, 2026
Merged

docker: reuse tested images for artifact uploads#177
dhalperi merged 1 commit into
masterfrom
reuse-tested-artifacts-for-release

Conversation

@dhalperi

Copy link
Copy Markdown
Member

Publish the architecture-specific image artifacts built during precommit
instead of rebuilding them during the development upload. Assemble the
tested multi-platform manifests from those images, and promote those
manifests for production. Skip development uploads during the production
workflow invocation.


Prompt:

I am confused by the upload_dev and upload_prod steps in the
cross-version-test-and-upload workflow.

I would expect that we build the wheel and containers exactly once. We
would upload them as test artifacts and test them, then we would promote
the SAME ARTIFACTS to production by uploading them to real pypi (for
pybatfish) or just adding new labels (docker batfish/allinone). It doesn't
seem that's how it works.

@batfish-bot

Copy link
Copy Markdown

This change is Reviewable

@dhalperi dhalperi left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhalperi reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dhalperi).

Publish the architecture-specific image artifacts built during precommit
instead of rebuilding them during the development upload. Assemble the
tested multi-platform manifests from those images, and promote those
manifests for production. Skip development uploads during the production
workflow invocation.

----

Prompt:
```
I am confused by the upload_dev and upload_prod steps in the
cross-version-test-and-upload workflow.

I would expect that we build the wheel and containers exactly once. We
would upload them as test artifacts and test them, then we would promote
the SAME ARTIFACTS to production by uploading them to real pypi (for
pybatfish) or just adding new labels (docker batfish/allinone). It doesn't
seem that's how it works.
```
@dhalperi
dhalperi force-pushed the reuse-tested-artifacts-for-release branch from e16398e to 3efb15e Compare August 27, 2026 20:50

@dhalperi dhalperi left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhalperi reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dhalperi).

@dhalperi
dhalperi enabled auto-merge (squash) August 27, 2026 20:57
@dhalperi
dhalperi merged commit d076c17 into master Aug 27, 2026
14 checks passed
@dhalperi
dhalperi deleted the reuse-tested-artifacts-for-release branch August 27, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants