fix(ingress-controller): PodDisruptionBudget references undefined helpers - #372
Open
janiussyafiq wants to merge 1 commit into
Open
fix(ingress-controller): PodDisruptionBudget references undefined helpers#372janiussyafiq wants to merge 1 commit into
janiussyafiq wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Comment |
janiussyafiq
force-pushed
the
fix/ingress-controller-pdb-helpers
branch
from
September 7, 2026 04:06
6910073 to
8e1807d
Compare
AlinsRan
approved these changes
Sep 7, 2026
…pers
pdb.yaml includes api7-ingress-controller.{fullname,labels,selectorLabels},
but _helpers.tpl only defines the api7-ingress-controller-manager.* names,
so any release with podDisruptionBudget.enabled=true and more than one
replica fails to render:
template: no template "api7-ingress-controller.fullname" associated with template "gotpl"
Use the defined helpers. The PDB selector now matches the Deployment's
selectorLabels. Bump the chart to 0.1.27 (chart-only fix,
appVersion unchanged).
Same defect as apache/apisix-helm-chart#946 / #968.
janiussyafiq
force-pushed
the
fix/ingress-controller-pdb-helpers
branch
from
September 7, 2026 09:18
8e1807d to
faa00c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charts/ingress-controller/templates/pdb.yamlincludesapi7-ingress-controller.{fullname,labels,selectorLabels}, but_helpers.tplonly defines theapi7-ingress-controller-manager.*names. Enabling the PDB with more than one replica fails to render:Use the defined
api7-ingress-controller-manager.*helpers. The PDB selector now matches the Deployment's selector labels.Bumps the chart to 0.1.27 (chart-only fix,
appVersionstays 2.2.0), README regenerated with helm-docs v1.13.1.Same defect as apache/apisix-helm-chart#946, fixed upstream by apache/apisix-helm-chart#968.