Skip to content

feat(pyamber): honor output port lookup - #8276

Open
carloea2 wants to merge 1 commit into
apache:mainfrom
carloea2:fix/honor-output-port-lookup
Open

feat(pyamber): honor output port lookup#8276
carloea2 wants to merge 1 commit into
apache:mainfrom
carloea2:fix/honor-output-port-lookup

Conversation

@carloea2

@carloea2 carloea2 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Honor an explicit port ID when retrieving an output port. Calls without an ID retain the existing first-port behavior, while unknown explicit IDs now fail with KeyError.

Any related issues, documentation, discussions?

Closes #8274

How was this PR tested?

Added positive coverage for a requested nonfirst port and negative coverage for an unknown port.

C:\Users\carlo\texera\texera\.venv312\Scripts\python.exe -c "import sys,pytest; sys.path[:0]=[r'C:\Users\carlo\texera\texera-worktrees\investigate-bug73\amber\src\main\python',r'C:\Users\carlo\texera\texera\amber\src\main\python']; raise SystemExit(pytest.main([r'amber\src\test\python\core\architecture\packaging\test_output_manager.py','-p','no:cacheprovider','-q']))"

C:\Users\carlo\texera\texera\.venv312\Scripts\ruff.exe check amber/src/main/python/core/architecture/packaging/output_manager.py amber/src/test/python/core/architecture/packaging/test_output_manager.py

C:\Users\carlo\texera\texera\.venv312\Scripts\ruff.exe format --check amber/src/main/python/core/architecture/packaging/output_manager.py amber/src/test/python/core/architecture/packaging/test_output_manager.py

All 41 tests passed. Ruff checks passed.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Codex

@Yicong-Huang Yicong-Huang added the release/v1.2 back porting to release/v1.2 label Aug 31, 2026
@github-actions
github-actions Bot requested a review from xuang7 August 31, 2026 08:02
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Backport auto-label report

This fix: PR was checked against each actively-supported release branch. release/* labels drive the post-merge backport, so add or remove one to change where this fix lands.

Release branch Analysis
⚠️ release/v1.3 Not labeled automatically — none of the files this PR modifies exist on this branch (amber/src/main/python/core/architecture/packaging/output_manager.py, amber/src/test/python/core/architecture/packaging/test_output_manager.py). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. Please check and add release/v1.3 by hand if this fix should be backported here.
release/v1.2 Already labeled — this fix is queued to backport here.

Auto-label run.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @aglinxinyuan, @eugenegujing
    You can notify them by mentioning @aglinxinyuan, @eugenegujing in a comment.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.93%. Comparing base (50321e4) to head (990e4b5).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8276   +/-   ##
=========================================
  Coverage     93.93%   93.93%           
  Complexity     4761     4761           
=========================================
  Files          1191     1191           
  Lines         48308    48310    +2     
  Branches       5377     5377           
=========================================
+ Hits          45378    45380    +2     
  Misses         1495     1495           
  Partials       1435     1435           
Flag Coverage Δ *Carryforward flag
access-control-service 81.00% <ø> (ø) Carriedforward from 50321e4
agent-service 99.32% <ø> (ø) Carriedforward from 50321e4
amber 90.02% <ø> (ø) Carriedforward from 50321e4
computing-unit-managing-service 73.67% <ø> (ø) Carriedforward from 50321e4
config-service 86.86% <ø> (ø) Carriedforward from 50321e4
file-service 87.91% <ø> (ø) Carriedforward from 50321e4
frontend 96.41% <ø> (ø) Carriedforward from 50321e4
notebook-migration-service 79.31% <ø> (ø) Carriedforward from 50321e4
pyamber 98.87% <100.00%> (+<0.01%) ⬆️
workflow-compiling-service 77.19% <ø> (ø) Carriedforward from 50321e4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

✅ No material benchmark regressions detected

🟢 2 better · 🔴 0 worse · ⚪ 13 noise (<±5%) · 0 without baseline

Compared against main 50321e4 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
bs=10 sw=10 sl=64 421 0.257 24,303/32,863/32,863 us ⚪ within ±5% / 🔴 +110.9%
🟢 bs=100 sw=10 sl=64 945 0.577 106,482/127,281/127,281 us 🟢 -10.9% / 🔴 +18.7%
bs=1000 sw=10 sl=64 1,087 0.663 914,377/1,004,162/1,004,162 us ⚪ within ±5% / 🟢 -6.9%
Baseline details

Latest main 50321e4 from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 421 tuples/sec 417 tuples/sec 787.98 tuples/sec +1.0% -46.6%
bs=10 sw=10 sl=64 MB/s 0.257 MB/s 0.254 MB/s 0.481 MB/s +1.2% -46.6%
bs=10 sw=10 sl=64 p50 24,303 us 24,088 us 12,593 us +0.9% +93.0%
bs=10 sw=10 sl=64 p95 32,863 us 32,805 us 15,579 us +0.2% +110.9%
bs=10 sw=10 sl=64 p99 32,863 us 32,805 us 18,786 us +0.2% +74.9%
bs=100 sw=10 sl=64 throughput 945 tuples/sec 958 tuples/sec 1,008 tuples/sec -1.4% -6.2%
bs=100 sw=10 sl=64 MB/s 0.577 MB/s 0.585 MB/s 0.615 MB/s -1.4% -6.2%
bs=100 sw=10 sl=64 p50 106,482 us 101,445 us 100,701 us +5.0% +5.7%
bs=100 sw=10 sl=64 p95 127,281 us 142,836 us 107,244 us -10.9% +18.7%
bs=100 sw=10 sl=64 p99 127,281 us 142,836 us 116,122 us -10.9% +9.6%
bs=1000 sw=10 sl=64 throughput 1,087 tuples/sec 1,104 tuples/sec 1,042 tuples/sec -1.5% +4.3%
bs=1000 sw=10 sl=64 MB/s 0.663 MB/s 0.674 MB/s 0.636 MB/s -1.6% +4.2%
bs=1000 sw=10 sl=64 p50 914,377 us 897,286 us 981,959 us +1.9% -6.9%
bs=1000 sw=10 sl=64 p95 1,004,162 us 1,006,217 us 1,023,080 us -0.2% -1.8%
bs=1000 sw=10 sl=64 p99 1,004,162 us 1,006,217 us 1,051,697 us -0.2% -4.5%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,475.39,200,128000,421,0.257,24303.10,32862.71,32862.71
1,100,10,64,20,2116.28,2000,1280000,945,0.577,106481.91,127281.02,127281.02
2,1000,10,64,20,18399.89,20000,12800000,1087,0.663,914377.27,1004162.04,1004162.04

@carloea2 carloea2 changed the title fix(pyamber): honor output port lookup feat(pyamber): honor output port lookup Aug 31, 2026
@mengw15 mengw15 removed the release/v1.2 back porting to release/v1.2 label Aug 31, 2026
@xuang7 xuang7 removed the fix label Sep 1, 2026
@xuang7
xuang7 removed their request for review September 1, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output manager ignores requested port ID

5 participants