Skip to content

feat(pyamber): route range NaN keys - #8258

Open
carloea2 wants to merge 1 commit into
apache:mainfrom
carloea2:fix/route-range-nan-keys
Open

feat(pyamber): route range NaN keys#8258
carloea2 wants to merge 1 commit into
apache:mainfrom
carloea2:fix/route-range-nan-keys

Conversation

@carloea2

@carloea2 carloea2 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Python range shuffle now treats NaN keys as zero before bucket calculation, matching JVM double-to-long conversion. Finite and infinite key behavior remains unchanged.

Any related issues, documentation, discussions?

Closes #8257

How was this PR tested?

python -c "import sys,pytest; sys.path[:0]=[r'C:\Users\carlo\texera\texera-worktrees\investigate-bug65\amber\src\main\python',r'C:\Users\carlo\texera\texera\amber\src\main\python']; raise SystemExit(pytest.main(['amber/src/test/python/core/architecture/sendsemantics/test_partitioners.py','-q','-p','no:cacheprovider']))"
36 passed

ruff check amber/src/main/python amber/src/test/python
All checks passed

ruff format --check amber/src/main/python amber/src/test/python
213 files already formatted

Direct reproduction after the fix:

nan_index=1 receiver=B

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Codex

@Yicong-Huang Yicong-Huang added the release/v1.2 back porting to release/v1.2 label Aug 31, 2026
@github-actions
github-actions Bot requested a review from xuang7 August 31, 2026 05:34
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Backport auto-label report

This fix: PR was checked against each actively-supported release branch. release/* labels drive the post-merge backport, so add or remove one to change where this fix lands.

Release branch Analysis
⚠️ release/v1.3 Not labeled automatically — none of the files this PR modifies exist on this branch (amber/src/main/python/core/architecture/sendsemantics/range_based_shuffle_partitioner.py, amber/src/test/python/core/architecture/sendsemantics/test_partitioners.py). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. Please check and add release/v1.3 by hand if this fix should be backported here.
release/v1.2 Already labeled — this fix is queued to backport here.

Auto-label run.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @Ma77Ball, @Yicong-Huang
    You can notify them by mentioning @Ma77Ball, @Yicong-Huang in a comment.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

⚠️ Benchmark changes need a look

🟢 2 better · 🔴 6 worse · ⚪ 7 noise (<±5%) · 0 without baseline

Compared against main 50321e4 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🔴 bs=10 sw=10 sl=64 430 0.262 22,045/34,785/34,785 us 🔴 -11.8% / 🔴 +123.3%
🔴 bs=100 sw=10 sl=64 936 0.572 106,261/119,804/119,804 us 🔴 +5.8% / 🔴 +11.7%
🟢 bs=1000 sw=10 sl=64 1,106 0.675 899,419/962,898/962,898 us 🟢 -8.0% / 🟢 -8.4%
Baseline details

Latest main 50321e4 from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 430 tuples/sec 486 tuples/sec 787.98 tuples/sec -11.5% -45.4%
bs=10 sw=10 sl=64 MB/s 0.262 MB/s 0.297 MB/s 0.481 MB/s -11.8% -45.5%
bs=10 sw=10 sl=64 p50 22,045 us 19,925 us 12,593 us +10.6% +75.1%
bs=10 sw=10 sl=64 p95 34,785 us 31,129 us 15,579 us +11.7% +123.3%
bs=10 sw=10 sl=64 p99 34,785 us 31,129 us 18,786 us +11.7% +85.2%
bs=100 sw=10 sl=64 throughput 936 tuples/sec 975 tuples/sec 1,008 tuples/sec -4.0% -7.1%
bs=100 sw=10 sl=64 MB/s 0.572 MB/s 0.595 MB/s 0.615 MB/s -3.9% -7.0%
bs=100 sw=10 sl=64 p50 106,261 us 100,422 us 100,701 us +5.8% +5.5%
bs=100 sw=10 sl=64 p95 119,804 us 125,815 us 107,244 us -4.8% +11.7%
bs=100 sw=10 sl=64 p99 119,804 us 125,815 us 116,122 us -4.8% +3.2%
bs=1000 sw=10 sl=64 throughput 1,106 tuples/sec 1,084 tuples/sec 1,042 tuples/sec +2.0% +6.1%
bs=1000 sw=10 sl=64 MB/s 0.675 MB/s 0.662 MB/s 0.636 MB/s +2.0% +6.1%
bs=1000 sw=10 sl=64 p50 899,419 us 911,341 us 981,959 us -1.3% -8.4%
bs=1000 sw=10 sl=64 p95 962,898 us 1,046,764 us 1,023,080 us -8.0% -5.9%
bs=1000 sw=10 sl=64 p99 962,898 us 1,046,764 us 1,051,697 us -8.0% -8.4%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,465.47,200,128000,430,0.262,22044.74,34784.83,34784.83
1,100,10,64,20,2135.93,2000,1280000,936,0.572,106261.02,119804.01,119804.01
2,1000,10,64,20,18076.01,20000,12800000,1106,0.675,899419.28,962897.75,962897.75

@Yicong-Huang

Copy link
Copy Markdown
Contributor

I am converting this PR to a draft: please follow our PR template and mark it ready for review.

@Yicong-Huang
Yicong-Huang marked this pull request as draft August 31, 2026 19:56
@carloea2
carloea2 marked this pull request as ready for review August 31, 2026 20:12
@carloea2

Copy link
Copy Markdown
Contributor Author

The description now follows the current template, and this is ready for review.

@carloea2 carloea2 changed the title fix(pyamber): route range NaN keys feat(pyamber): route range NaN keys Aug 31, 2026
@mengw15 mengw15 removed the release/v1.2 back porting to release/v1.2 label Aug 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.90%. Comparing base (50321e4) to head (7c8830d).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8258      +/-   ##
============================================
- Coverage     93.93%   93.90%   -0.04%     
+ Complexity     4762     4761       -1     
============================================
  Files          1191     1191              
  Lines         48308    49054     +746     
  Branches       5377     5377              
============================================
+ Hits          45380    46062     +682     
- Misses         1494     1557      +63     
- Partials       1434     1435       +1     
Flag Coverage Δ *Carryforward flag
access-control-service 81.00% <ø> (ø) Carriedforward from 50321e4
agent-service 99.32% <ø> (ø) Carriedforward from 50321e4
amber 90.02% <ø> (-0.02%) ⬇️ Carriedforward from 50321e4
computing-unit-managing-service 73.67% <ø> (ø) Carriedforward from 50321e4
config-service 86.86% <ø> (ø) Carriedforward from 50321e4
file-service 87.91% <ø> (ø) Carriedforward from 50321e4
frontend 96.41% <ø> (ø) Carriedforward from 50321e4
notebook-migration-service 79.31% <ø> (ø) Carriedforward from 50321e4
pyamber 97.87% <100.00%> (-1.00%) ⬇️
workflow-compiling-service 77.19% <ø> (ø) Carriedforward from 50321e4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xuang7 xuang7 removed the fix label Sep 1, 2026
@xuang7
xuang7 removed their request for review September 1, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NaN keys crash Python range shuffle

5 participants