[AURON #2499] perf: avoid identity take in GenerateExec - #2500
Open
lyne7-sc wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2499
Rationale for this change
Avoid redundant generated-array copies during non-outer
GenerateExec.What changes are included in this PR?
outeris false.takepath for outer generation.takerequired to duplicate parent rows.Are there any user-facing changes?
No. This is an internal performance improvement.
How was this patch tested?
Existed unit tests passed.
Benchmarks
The benchmark uses 10,000 input rows with 8 values per row. The reported values are averages of two runs.
explode_array_i32posexplode_array_i32explode_map_utf8_i32explode_array_i32_parent_null_gapsWas this patch authored or co-authored using generative AI tooling?
If yes, include:
Generated-by: <tool name and version>ASF guidance: https://www.apache.org/legal/generative-tooling.html