Enable skillscope workflows on Windows - #13
Merged
Conversation
A behavioral leg lands on whatever platform its skill asked for, so a step that names bash is a bet that the runner has bash. Hosted Windows carries Git Bash and wins that bet; a self-hosted Windows box need not, and there `Install the claude CLI` fails as `bash: command not found` -- on a step whose actual job is npm. Before the harness moved into this repo, the same command was a workflow step with no `shell:` at all, so it took the runner's default: bash on Linux, PowerShell on Windows. A composite action cannot do that. GitHub requires a shell on every `run:`, `bash` was the one named, and Windows support regressed with it. So write the steps that can reach a caller's runner in Python, the only shell the three platforms are guaranteed to agree on -- which is what the launcher beside it already does, and for this reason. That is the claude install in action.yml, the four bash steps in reusable.yml, and the aggregate in skill-evals.yml, whose `coordinator_runner` is an input like any other. selftest.yml keeps its bash: that matrix is ours. Add a test that reads the three files and fails on a `run:` step under any other shell, because nothing else would. `install-claude` is set by no job in selftest.yml, so that step has never executed in this repo's CI on any platform -- and on hosted Windows it would have passed regardless.
danielholanda
changed the title
danielholanda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every behavioral leg on a self-hosted Windows runner currently fails before it grades anything:
The step is
Install the claude CLIinaction.yml, and the shell it names is the whole of the bug:Why it regressed
The fix
Write the steps that can land on a caller's runner in Python: the only shell all three platforms are guaranteed to agree on.