Skip to content

Separate OAuth2 grant validation - #3639

Merged
adamtheturtle merged 1 commit into
mainfrom
cleanup/oauth-grant-validation
Sep 13, 2026
Merged

adamtheturtle merged 1 commit into
mainfrom
cleanup/oauth-grant-validation

Conversation

@adamtheturtle

Copy link
Copy Markdown
Member

The OAuth2 token handler combined request parsing, grant dispatch, two distinct authentication workflows, scope validation, and response construction. That required both Ruff and Pylint complexity suppressions.

This splits the client-credentials and password-grant validation into focused functions and shares only the access-token response construction. The public endpoint behavior and exact response payloads remain unchanged.

Validation:

  • all configured pre-commit and pre-push hooks
  • full non-real-backend suite: 1,957 passed, 833 skipped
  • changed production module: 100% local statement and branch coverage
  • hosted coverage remains authoritative for real-service and platform-only partitions

@adamtheturtle

Copy link
Copy Markdown
Member Author

The exact-head Test workflow is terminal. In addition to the two ProjectSuspended failures already present on current main, the real-Vuforia missing-basic-auth case could not connect to vws.vuforia.com/oauth2/token and exhausted its retries with ConnectTimeout. That external abort caused the combined coverage job to see 99%. The full non-real suite passes locally (1,957 passed, 833 skipped), and the changed production module is at 100% local statement and branch coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant