Skip to content

Start resource cleanup after creation - #3638

Merged
adamtheturtle merged 1 commit into
mainfrom
cleanup/resource-finalizers
Sep 13, 2026
Merged

adamtheturtle merged 1 commit into
mainfrom
cleanup/resource-finalizers

Conversation

@adamtheturtle

Copy link
Copy Markdown
Member

Three Model Target public-interface tests initialized a resource ID to None before entering try/finally, so coverage needed no branch exclusions on the guarded cleanup.

Create and validate each resource first, then enter try/finally with a concrete string ID. Cleanup is now unconditional whenever a resource exists, the optional-state bookkeeping disappears, and all three coverage pragmas are removed.

Validation:

  • focused public-interface cases: 8 passed, 4 real-backend cases skipped locally
  • all configured pre-commit, pre-push, and manual hooks
  • full non-real suite: 1,957 passed, 833 skipped
  • the changed test paths are covered locally; the repository-wide 100% gate requires the configured hosted real/skip/Windows coverage partitions

@adamtheturtle

Copy link
Copy Markdown
Member Author

The exact-head Test rerun is terminal. The changed Model Target Web API module passed, as did Combine & check coverage at 100%. The only root failures are the same real-Vuforia TestSuccess and TestIncludeTargetData ProjectSuspended cases present on current main; completion-ci is their aggregate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant