Skip to content

Document the required private HTTPX2 hook - #3635

Merged
adamtheturtle merged 2 commits into
mainfrom
cleanup/document-httpx2-private-hook
Sep 12, 2026
Merged

adamtheturtle merged 2 commits into
mainfrom
cleanup/document-httpx2-private-hook

Conversation

@adamtheturtle

Copy link
Copy Markdown
Member

Issue

MockVWS deliberately patches HTTPX2's private sync and async transport selectors so it can intercept clients created before the mock starts. The narrow Pylint, Ruff, and Pyright suppressions did not explain why a public API could not replace that access.

HTTPX has the same private-only selector, and RESPX patches it in the same way, so HTTPX2 does not currently lag a public HTTPX extension point and no HTTPX2 parity issue is appropriate.

Change

Add a concise comment beside the suppressions linking to RESPX's permanent source revision and explaining the existing-client requirement.

Validation

  • All configured pre-commit hooks
  • All configured pre-push hooks, including Mypy, Pyright, verifytypes, Ty, Pyrefly, docs, manifest, and partition checks
  • Full credential-free non-Docker suite: 1,941 passed, 849 skipped
  • Docker-backed suite: 6 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant