Skip to content

DOCS: deleted the three orphaned PNGs - #2481

Merged
josepmariapujol-unity merged 1 commit into
developfrom
input/ci-fixing-images-left-unused
Sep 9, 2026
Merged

DOCS: deleted the three orphaned PNGs#2481
josepmariapujol-unity merged 1 commit into
developfrom
input/ci-fixing-images-left-unused

Conversation

@josepmariapujol-unity

@josepmariapujol-unity josepmariapujol-unity commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixing CI failing after landing documentation PR.

Screenshot 2026-09-09 at 10 10 18

Cause: commit 8fba100 ("DOCS: 6.7 package installation update", #2470) rewrote Installation.md, replacing the three screenshot embeds (Images/EditorRestartWarning.png, Images/ActiveInputHandling.png, Images/InstallSamples.png) with prose and numbered steps, but left the image files in place.

Fix: deleted the three orphaned PNGs (staged via git rm; Documentation~ is excluded from Unity import, so there are no .meta files to clean up).

Testing status & QA

Running CI jobs again.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity self-assigned this Sep 9, 2026
@josepmariapujol-unity josepmariapujol-unity changed the title FIX: deleted the three orphaned PNGs DOCS: deleted the three orphaned PNGs Sep 9, 2026
@josepmariapujol-unity
josepmariapujol-unity marked this pull request as ready for review September 9, 2026 08:09

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

The change removes three documentation image assets with no remaining filename references or associated metadata, while the installation guidance now presents the relevant instructions as text. I also checked the surrounding documentation asset references for dependencies on the deleted files.

Reviewed commit 7d01e64

🤖 Helpful? 👍/👎

@codecov-github-com

codecov-github-com Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2481      +/-   ##
===========================================
- Coverage    78.95%   78.94%   -0.01%     
===========================================
  Files          767      767              
  Lines       140780   140914     +134     
===========================================
+ Hits        111153   111251      +98     
- Misses       29627    29663      +36     
Flag Coverage Δ
inputsystem_MacOS_6000.0_project 77.49% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3 5.30% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 77.49% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5 5.29% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5_project 77.54% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.6 5.29% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.6_project 77.54% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.7 5.29% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.7_project 77.54% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0 5.31% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.40% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3 5.31% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.39% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5 5.30% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.45% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.6 5.30% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.6_project 77.45% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.7 5.30% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.7_project 77.45% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0 5.30% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 77.61% <ø> (+0.04%) ⬆️
inputsystem_Windows_6000.3 5.30% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 77.61% <ø> (+0.04%) ⬆️
inputsystem_Windows_6000.5 5.29% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.5_project 77.67% <ø> (+0.04%) ⬆️
inputsystem_Windows_6000.6 5.29% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.6_project 77.67% <ø> (+0.04%) ⬆️
inputsystem_Windows_6000.7 5.29% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.7_project 77.67% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

ℹ️ Need help interpreting these results?

@suearkinunity suearkinunity left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that

@josepmariapujol-unity
josepmariapujol-unity merged commit ac101d8 into develop Sep 9, 2026
108 of 114 checks passed
@josepmariapujol-unity
josepmariapujol-unity deleted the input/ci-fixing-images-left-unused branch September 9, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants