feat: Add dependency state check for cached snapshots - #486
Draft
lukasmi93 wants to merge 1 commit into
Draft
Conversation
Add dependency state check for cached snapshots
lukasmi93
force-pushed
the
fix/snapshot-cache-dependency-check
branch
from
September 7, 2026 15:34
7f9fe00 to
19bf8f5
Compare
| } | ||
| respond_json(request, 200, &metrics(state)) | ||
| } | ||
| "/impacted_targets" | "/impacted_targets_with_distances" | "/dependency_edges" => { |
Collaborator
There was a problem hiding this comment.
Why was this route /dependency_edges removed?
| } | ||
| }; | ||
| let kind = match path { | ||
| "/dependency_edges" => QueryKind::DepEdges, |
Collaborator
There was a problem hiding this comment.
Same here, why are we removing routes?
| .filter(|types| !types.is_empty()) | ||
| } | ||
|
|
||
| fn compute_query(state: &Arc<State>, inputs: QueryInputs, kind: QueryKind) -> Result<Value> { |
Collaborator
There was a problem hiding this comment.
Lets revert this, use the enum
| let resolve_started = Instant::now(); | ||
| let (from_sha, to_sha) = resolve_both(state, &inputs.from, &inputs.to)?; | ||
| let resolve_millis = resolve_started.elapsed().as_millis() as u64; | ||
| if matches!(kind, QueryKind::DepEdges) { |
Collaborator
There was a problem hiding this comment.
Unsure why this was deleted, bring it back
| let exclude_external = state.config.hash_options.bazel.is_bzlmod_enabled(); | ||
| let impacted = | ||
| impacted_with_module_changes(&from, &to, Some(&state.config.hash_options.bazel))?; | ||
| let impacted_value = if matches!(kind, QueryKind::Distances) { |
Collaborator
There was a problem hiding this comment.
I like the enum over your bool trap
| modified_filepaths: BTreeSet::new(), | ||
| profile: true, | ||
| }; | ||
| let result = compute_query(&state, inputs, QueryKind::Distances).unwrap(); |
Collaborator
There was a problem hiding this comment.
Why is so much overwritten here, can we find a way to make this easier to reason about. Ask your agent maybe to optimize for review over reformatting the whole file and rearranging the logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dependency state check for cached snapshots