Fix MMAP reference validation tests - #105
Merged
Merged
Conversation
GiggleLiu
force-pushed
the
automanage/mmap-reference-lower-bounds
branch
from
September 8, 2026 20:33
ab3098b to
8fcf6f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Segmentation 13 and 14 tests compared assignments against external solver output, even though those assignments are feasible results rather than certified optima. Independently scoring both assignments shows TensorInference's candidates have higher log objectives by 31.5093806324 and 3.1385028268 respectively.
This restores all three cases and checks that the returned assignment reproduces the reported objective and meets the external feasible lower bound. It also adds an independent exhaustive oracle over small MMAP models. The oracle derives expected output variables directly from the query and evidence, verifies the model exposes that order, and brute-force enumerates assignment scores without using TensorInference contraction results. A better external score alone is not treated as proof of global optimality.
This is the first agent-created maintenance PR for the repository, so it also adds the required maintenance badge.
Validation:
test/mmap.jl: 202/202 assertions passed (CUDA excluded)git diff --checkCloses #42.
Closes #79.