main fcl change - #951
Open
Jjm321814 wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @linyan-w, just checking in to see if you able to review this PR? @Jjm321814 , maybe you can add reviewers from PR#939 as well since they already reviewed the develop version? |
Contributor
Author
|
Ah sorry the other one has some feedback I need to address. I should be able to get these all ironed out next week |
Contributor
|
No worries, thanks @Jjm321814 ! |
Contributor
|
Hi yes! Once all the dev version PRs settles (this one still pending) we can merge. Thank you Alex and Jacob! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of PR 939 #939 but aimed at production branch