Make grafana viewable - #175
Open
jeremyestein wants to merge 4 commits into
Open
Conversation
PR checklistDefault guide for a PR (if multiple PRs for the work, only keep one version of it and link to it on the other PRs)
|
thompson318
reviewed
Sep 7, 2026
thompson318
left a comment
Contributor
There was a problem hiding this comment.
I couldn't see much wrong with it. I ran it through Claude code which raised a couple of issues with proxy_pass. I've included them as suggestions here. Apologies if they're no use. Let me know if you need more explanation.
| include conf.d/shared/shared_location_config.conf; | ||
| proxy_pass http://glowroot-central:4000/; | ||
| set $glowroot_upstream http://glowroot-central:4000; | ||
| proxy_pass $glowroot_upstream/; |
Contributor
There was a problem hiding this comment.
Suggested change
| proxy_pass $glowroot_upstream/; | |
| # proxy_pass with a variable can't strip the location prefix itself, | |
| # so strip it with rewrite (which preserves the query string) first. | |
| rewrite ^/glowroot/(.*)$ /$1 break; | |
| proxy_pass $glowroot_upstream; |
My URI and proxy knowledge isn't great. This suggestion came from Claude.
| include conf.d/shared/shared_location_config.conf; | ||
| proxy_pass http://streamlit:8501/streamlit/; | ||
| set $streamlit_upstream http://streamlit:8501; | ||
| proxy_pass $streamlit_upstream/streamlit/; |
Contributor
There was a problem hiding this comment.
Suggested change
| proxy_pass $streamlit_upstream/streamlit/; | |
| # No URI part after the variable, so the full original request URI | |
| # (including the /streamlit/ prefix, path and query string) is | |
| # forwarded unchanged. | |
| proxy_pass $streamlit_upstream; |
This also came from Claude. It makes sense to me in that adding the streamlit suffix will remove any query string ie. /streamlit/page1?foo=bar would become just /streamlit/. Is that an issue for us?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SAFEHR-data/waveform-controller#92
Tightly coupled to SAFEHR-data/waveform-controller#94
Add Waveform Grafana to the Emap portal reverse proxy.
This is intended to be temporary, as we will have GAE-level grafana (etc) in the near future. Therefore I have not worried about what will happen if the manually-created docker network that connects the containers is absent.