Skip to content

Avoid -Wunused-parameter warnings #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enchufa2 merged 4 commits into from
Sep 3, 2026
Merged

Avoid -Wunused-parameter warnings #1506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1f9eb5
add -Wall -Wextra
Enchufa2 Sep 3, 2026
7750a32
fix unused-parameter warnings
Enchufa2 Sep 3, 2026
ad9d7d2
update ChangeLog
Enchufa2 Sep 3, 2026
1ea9c31
switch to gcc16
Enchufa2 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/werror.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ on:

env:
_R_CHECK_FORCE_SUGGESTS_: "false"
RCPP_CXXFLAGS: "-Werror -Wcast-function-type -Wdeprecated-copy -Wimplicit-fallthrough"
RCPP_CXXFLAGS: "-Werror -Wall -Wextra"

@eddelbuettel eddelbuettel Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@Enchufa2 Enchufa2 Sep 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-W


jobs:
ci:
runs-on: ubuntu-latest
container: rocker/drd
container: eddelbuettel/drd:26.04

steps:
- name: Checkout
Expand Down
23 changes: 23 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,29 @@
* inst/include/Rcpp/vector/RangeIndexer.h: Idem
* inst/include/Rcpp/macros/unroll.h: Idem

* .github/workflows/werror.yaml: Add -Wall -Wextra, substituting the
previous ones, which enables them but also -Wunused-parameter and more,
and switch to a container with gcc16

* src/api.cpp: Comment out parameters to avoid -Wunused-parameter warnings
* inst/include/Rcpp/Module.h: Idem
* inst/include/Rcpp/Promise.h: Idem
* inst/include/Rcpp/StretchyList.h: Idem
* inst/include/Rcpp/internal/wrap.h: Idem
* inst/include/Rcpp/module/Module_Field.h: Idem
* inst/include/Rcpp/sugar/functions/cbind.h: Idem
* inst/include/Rcpp/sugar/functions/is_na.h: Idem
* inst/include/Rcpp/sugar/matrix/col.h: Idem
* inst/include/Rcpp/sugar/matrix/row.h: Idem
* inst/include/Rcpp/sugar/operators/Comparator_With_One_Value.h: Idem
* inst/include/Rcpp/sugar/tools/safe_math.h: Idem
* inst/include/Rcpp/vector/Subsetter.h: Idem
* inst/include/Rcpp/vector/Vector.h: Idem
* inst/tinytest/cpp/InternalFunction.cpp: Idem
* inst/tinytest/cpp/attributes.cpp: Reference parameters in the body instead
* inst/tinytest/cpp/ListOf.cpp: Idem
* inst/tinytest/cpp/Vector.cpp: Idem

2026-09-01 Iñaki Ucar <iucar@fedoraproject.org>

* .github/workflows/werror.yaml: Add new CI file with -Werror enabled
Expand Down
4 changes: 2 additions & 2 deletions inst/include/Rcpp/Module.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ namespace Rcpp{

private:
template <int... Is>
Class* get_new_impl(SEXP* args, int nargs, traits::index_sequence<Is...>) {
Class* get_new_impl(SEXP* args, int /*nargs*/, traits::index_sequence<Is...>) {
return new Class( as<T>(args[Is])... ) ;
}
};
Expand All @@ -222,7 +222,7 @@ namespace Rcpp{
class Factory : public Factory_Base<Class> {
public:
Factory( Class* (*fun)(T...) ) : ptr_fun(fun){}
virtual Class* get_new( SEXP* args, int nargs ){
virtual Class* get_new( SEXP* args, int /*nargs*/ ){
return get_new( args, traits::make_index_sequence<sizeof...(T)>() ) ;
}
virtual int nargs(){ return sizeof...(T) ; }
Expand Down
2 changes: 1 addition & 1 deletion inst/include/Rcpp/Promise.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ namespace Rcpp{
return Environment( PRENV(Storage::get__() ) ) ;
}

inline void update(SEXP data){}
inline void update(SEXP /*data*/){}

} ;

Expand Down
2 changes: 1 addition & 1 deletion inst/include/Rcpp/StretchyList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ namespace Rcpp{
Storage::set__(r_cast<LISTSXP>(x)) ;
}

void update(SEXP x){}
void update(SEXP /*x*/){}

inline operator SEXP() const{
return CDR(Storage::get__() );
Expand Down
2 changes: 1 addition & 1 deletion inst/include/Rcpp/internal/wrap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,7 @@ namespace Rcpp {
template <> inline SEXP wrap<Rcpp::String>(const Rcpp::String& object);

template <typename T>
inline SEXP module_wrap_dispatch(const T& obj, Rcpp::traits::void_wrap_tag) {
inline SEXP module_wrap_dispatch(const T& /*obj*/, Rcpp::traits::void_wrap_tag) {
return R_NilValue;
}

Expand Down
2 changes: 1 addition & 1 deletion inst/include/Rcpp/module/Module_Field.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class CppProperty_Getter : public CppProperty<Class> {
prop_class(doc), ptr(ptr_), class_name(DEMANGLE(PROP)) {}

SEXP get(Class* object) { return Rcpp::wrap( object->*ptr ) ; }
void set(Class* object, SEXP value) { throw std::range_error("read only data member") ; }
void set(Class* /*object*/, SEXP /*value*/) { throw std::range_error("read only data member") ; }
bool is_readonly(){ return true ; }
std::string get_class(){ return class_name; }

Expand Down
12 changes: 6 additions & 6 deletions inst/include/Rcpp/sugar/functions/cbind.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,11 @@ class ScalarBindable

inline R_xlen_t ncol() const { return 1; }

inline stored_type operator[](R_xlen_t i) const {
inline stored_type operator[](R_xlen_t /*i*/) const {
return t;
}
inline stored_type operator()(R_xlen_t i, R_xlen_t j) const {

inline stored_type operator()(R_xlen_t /*i*/, R_xlen_t /*j*/) const {
return t;
}
};
Expand Down Expand Up @@ -442,8 +442,8 @@ template <typename T>
inline typename Rcpp::traits::enable_if<
has_stored_type<T>::value,
MakeBindableCall<T, true>
>::type
MakeBindable(const T& t) {
>::type
MakeBindable(const T& /*t*/) {
return MakeBindableCall<T, true>();
}

Expand All @@ -452,7 +452,7 @@ inline typename Rcpp::traits::enable_if<
!has_stored_type<T>::value,
MakeBindableCall<T, false>
>::type
MakeBindable(const T& t) {
MakeBindable(const T& /*t*/) {
return MakeBindableCall<T, false>();
}

Expand Down
2 changes: 1 addition & 1 deletion inst/include/Rcpp/sugar/functions/is_na.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class IsNa<RTYPE,false,VEC_TYPE> : public ::Rcpp::VectorBase< LGLSXP, false, IsN

IsNa( const BASE& obj_) : obj(obj_){}

inline int operator[]( R_xlen_t i ) const {
inline int operator[]( R_xlen_t /*i*/ ) const {
return FALSE ;
}

Expand Down
2 changes: 1 addition & 1 deletion inst/include/Rcpp/sugar/matrix/col.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class Col : public MatrixBase<

Col( const LHS_TYPE& lhs) : nr( lhs.ncol() ), nc( lhs.ncol() ) {}

inline int operator()( int i, int j ) const {
inline int operator()( int /*i*/, int j ) const {
return j + 1 ;
}

Expand Down
2 changes: 1 addition & 1 deletion inst/include/Rcpp/sugar/matrix/row.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class Row : public MatrixBase<

Row( const LHS_TYPE& lhs) : nr( lhs.nrow() ), nc( lhs.ncol() ) {}

inline int operator()( int i, int j ) const {
inline int operator()( int i, int /*j*/ ) const {
return i + 1 ;
}

Expand Down
4 changes: 2 additions & 2 deletions inst/include/Rcpp/sugar/operators/Comparator_With_One_Value.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class Comparator_With_One_Value : public ::Rcpp::VectorBase< LGLSXP, true, Compa
METHOD m ;
Operator op ;

inline int rhs_is_na(int i) const { return rhs ; }
inline int rhs_is_na(int /*i*/) const { return rhs ; }
inline int rhs_is_not_na(int i) const {
STORAGE x = lhs[i] ;
return Rcpp::traits::is_na<RTYPE>(x) ? NA_INTEGER : op( x, rhs ) ;
Expand Down Expand Up @@ -93,7 +93,7 @@ class Comparator_With_One_Value<RTYPE,Operator,false,T> :
METHOD m ;
Operator op ;

inline int rhs_is_na(int i) const { return rhs ; }
inline int rhs_is_na(int /*i*/) const { return rhs ; }
inline int rhs_is_not_na(int i) const {
return op( lhs[i], rhs ) ;
}
Expand Down
6 changes: 3 additions & 3 deletions inst/include/Rcpp/sugar/tools/safe_math.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ namespace detail {

template <typename T>
inline typename std::enable_if<!std::is_integral<T>::value, T>::type
safe_add(T a, T b, const char* caller = nullptr) { return a + b; }
safe_add(T a, T b, const char* /*caller*/ = nullptr) { return a + b; }

// Subtraction
template <typename T>
Expand All @@ -94,7 +94,7 @@ namespace detail {

template <typename T>
inline typename std::enable_if<!std::is_integral<T>::value, T>::type
safe_sub(T a, T b, const char* caller = nullptr) { return a - b; }
safe_sub(T a, T b, const char* /*caller*/ = nullptr) { return a - b; }

// Multiplication
template <typename T>
Expand Down Expand Up @@ -123,7 +123,7 @@ namespace detail {

template <typename T>
inline typename std::enable_if<!std::is_integral<T>::value, T>::type
safe_mul(T a, T b, const char* caller = nullptr) { return a * b; }
safe_mul(T a, T b, const char* /*caller*/ = nullptr) { return a * b; }

} // namespace detail
} // namespace sugar
Expand Down
8 changes: 4 additions & 4 deletions inst/include/Rcpp/vector/Subsetter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class SubsetProxy {
#endif
}

void get_indices( traits::identity< traits::int2type<INTSXP> > t ) {
void get_indices( traits::identity< traits::int2type<INTSXP> > /*t*/ ) {
indices.reserve(rhs_n);
int* ptr = INTEGER(rhs); // ok to use int * here, we'll catch any problems inside check_indices
check_indices(ptr, rhs_n, lhs_n);
Expand All @@ -157,7 +157,7 @@ class SubsetProxy {
indices_n = rhs_n;
}

void get_indices( traits::identity< traits::int2type<REALSXP> > t ) {
void get_indices( traits::identity< traits::int2type<REALSXP> > /*t*/ ) {
indices.reserve(rhs_n);
std::vector<R_xlen_t> tmp(rhs.size()); // create temp R_xlen_t type indices from reals
for(size_t i = 0 ; i < tmp.size() ; ++i) {
Expand All @@ -170,7 +170,7 @@ class SubsetProxy {
indices_n = rhs_n;
}

void get_indices( traits::identity< traits::int2type<STRSXP> > t ) {
void get_indices( traits::identity< traits::int2type<STRSXP> > /*t*/ ) {
indices.reserve(rhs_n);
SEXP names = Rf_getAttrib(lhs, R_NamesSymbol);
if (Rf_isNull(names)) stop("names is null");
Expand All @@ -185,7 +185,7 @@ class SubsetProxy {
indices_n = indices.size();
}

void get_indices( traits::identity< traits::int2type<LGLSXP> > t ) {
void get_indices( traits::identity< traits::int2type<LGLSXP> > /*t*/ ) {
indices.reserve(rhs_n);
if (lhs_n != rhs_n) {
stop("logical subsetting requires vectors of identical size");
Expand Down
2 changes: 1 addition & 1 deletion inst/include/Rcpp/vector/Vector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ class Vector :
}

template <typename U>
static void replace_element__dispatch( traits::false_type, iterator it, SEXP names, R_xlen_t index, const U& u){
static void replace_element__dispatch( traits::false_type, iterator it, SEXP /*names*/, R_xlen_t /*index*/, const U& u){
*it = converter_type::get(u);
}

Expand Down
2 changes: 1 addition & 1 deletion inst/tinytest/cpp/InternalFunction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ int add(int a, int b) {
return a + b;
}

void dummy(int a, int b) {
void dummy(int /*a*/, int /*b*/) {
Rcpp::Rcout << "dummy called" << std::endl;
}

Expand Down
1 change: 1 addition & 0 deletions inst/tinytest/cpp/ListOf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ NumericVector test_sapply_sum(NVList x) {

// [[Rcpp::export]]
NVList test_assign(NVList x, NumericVector y, CharacterVector z) {
(void)z;
x[1] = y;
x[2] = 1;
return x;
Expand Down
1 change: 1 addition & 0 deletions inst/tinytest/cpp/Vector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,7 @@ LogicalVector logical_vector_from_bool_assign() {

// [[Rcpp::export]]
void no_op(int major) {
(void)major;
//int minor = 1;
}

Expand Down
3 changes: 3 additions & 0 deletions inst/tinytest/cpp/attributes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,18 @@ std::string parse_declaration_test(std::string msg = "Parse function declaration

// [[Rcpp::export]]
std::string parse_default_values_with_str_parenthesis(const char* a = "(", const char* b= ")", std::string msg = "Parse function header with parenthis inside default string values.") {
(void)a; (void)b;
return msg;
}

// [[Rcpp::export]]
std::string parse_default_values_with_chr_parenthesis(char a = '(', char b= ')', std::string msg = "Parse function header with parenthis inside default char values.") {
(void)a; (void)b;
return msg;
}

// [[Rcpp::export]]
std::string parse_default_values_with_chr_backslash(char a = '\\', std::string msg = "Parse function header with backslash inside default char values.") {
(void)a;
return msg;
}
2 changes: 1 addition & 1 deletion src/api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ SEXP rcpp_can_use_cxx11() {
}

// [[Rcpp::register]]
SEXP stack_trace(const char* file, int line) {
SEXP stack_trace(const char* /*file*/, int /*line*/) {
return R_NilValue;
} // #nocov end

Expand Down
Loading