Remove the inert federal CCDF implementation - #9355
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9355 +/- ##
============================================
- Coverage 100.00% 67.24% -32.76%
============================================
Files 1 3 +2
Lines 35 58 +23
Branches 2 0 -2
============================================
+ Hits 35 39 +4
- Misses 0 19 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remove the inert New York-data federal CCDF path (part 1 of #9355)
Delete is_ccdf_eligible, is_ccdf_income_eligible, is_ccdf_reason_for_care_eligible, ccdf_income_to_smi_ratio, and ccdf_income with their tests, and reword the NY/SD prose that named them. The income_limit_smi parameter stays (MO CCS reads it), as does is_ccdf_age_eligible per the issue keep list. The partner analytics-coverage tests still reference these variables on purpose: their expected failure demonstrates the contract coverage. A dedicated follow-up commit will update the partner tests. Part of #9283 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Delete the two ccdf edge-case files, which existed solely to contract-test the removed chain; strip the is_ccdf_eligible output pins and is_ccdf_reason_for_care_eligible input lines from the MA signature tests; and drop the inert is_ccdf_reason_for_care_eligible inputs from the Head Start edge cases (nothing reads them, so no expected output changes). Partner was notified and approved removing both variables from their request surface. Fixes #9283 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1d4fd56 to
4853b91
Compare
|
Thanks for this, Ziming. I dug into the partner side before merging and split it in two. The NY-data path (your first commit) was safe, so I merged it as #9401. It touched no partner test, passed the full suite including Household API Partners on its own, and it is where the #9400 crash lived. The eligibility-chain removal needs partners to ship first. MyFriendBen's What I did to this branch. Rebased it onto main so it now carries only the chain half (your two commits, authorship intact), rewrote the changelog fragment for that scope since towncrier consumed the original on merge, and marked the PR draft until the partner side is settled. The remaining CCDF, NY CCAP, SD CCA, and childcare partner suites pass locally on the rebased head. |
Summary
Removes the inert federal CCDF implementation under
gov/hhs/ccdf/. The "federal" encoding was legacy New York data (market rates, copay percentages, county clusters), and the whole subsystem contributed $0 to every household:spm_unit_ccdf_subsidyis not listed inchild_care_subsidy_programs.yamlor any benefit aggregate. New York now has a proper state implementation (#9282) that reads none of these files.Fixes #9283
Changes
Commit 1 — inert NY legacy:
ccdf_age_group,ccdf_market_rate,ccdf_county_cluster,spm_unit_ccdf_subsidy,spm_unit_total_ccdf_copay,is_ccdf_home_based, and the orphan input stubsis_ccdf_initial_income_eligible,is_ccdf_continuous_income_eligibleamount.yaml(NY market rates),copay_percent.yaml,county_cluster.yamltests/policy/baseline/gov/hhs/ccdf/Commit 2 — the eligibility chain:
is_ccdf_eligible,is_ccdf_income_eligible,is_ccdf_reason_for_care_eligible,ccdf_income_to_smi_ratio,ccdf_income, and their 5 test filesHousehold API Partners, confirming the partner contract tests guard this surfaceCommit 3 — partner test update:
edge_cases/federal/childcare/ccdf/federal.yamlandccdf/ma.yaml(existed solely to contract-test the removed chain)signatures/ma.yaml: removed 20is_ccdf_eligibleoutput pins and 20is_ccdf_reason_for_care_eligibleinput linesis_ccdf_reason_for_care_eligibleinput lines (nothing reads them; no expected outputs change)Partner impact
The API partner was informed and approved removing
is_ccdf_eligible(appears in their requests as an output) andis_ccdf_reason_for_care_eligible(as an input).Kept — genuinely shared federal infrastructure
is_ccdf_asset_eligible(38 state readers),is_ccdf_immigration_eligible_child(41),meets_ccdf_activity_test(29),is_enrolled_in_ccdf,is_ccdf_age_eligible,child_care_subsidies,ccdf_duration_of_care(Idaho ICCP), and the shared parameters (asset_limit,age_limit,income_limit_smi— read by MO CCS,child_care_subsidy_programs).Testing
gov/hhs/ccdftests, 119 NY CCAP, 151 SD CCA, and 69 Idaho ICCP tests pass🤖 Generated with Claude Code