buffer: add optional -fbounds-safety annotations for struct buffer - #1105
Open
LaptopsPlural wants to merge 3 commits into
Open
LaptopsPlural wants to merge 3 commits into
LaptopsPlural wants to merge 3 commits into
Conversation
Introduce inert OVPN_SIZED_BY*_ macros (OFF by default) and annotate the struct buffer data/capacity pair used on packet paths. Capacity-first assign already present in alloc paths (documented). Default builds unchanged; ENABLE_FBOUNDS_SAFETY / --enable-fbounds-safety opt-in for experimental Clang toolchains. Signed-off-by: Jeff <jeff@incrediblybased.co>
Align trailing comments and preprocessor macros with project .clang-format so the style CI check passes. Signed-off-by: Jeff <jeff@incrediblybased.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Secure-by-design memory-safety hardening. Annotates
struct buffer.datawith optional Clang-fbounds-safety/ sized-by macros tied tocapacity. Default builds unchanged (ENABLE_FBOUNDS_SAFETYOFF).Per CONTRIBUTING: GitHub PRs are for discussion; will also send
git format-patchto openvpn-devel / Gerrit for merge.Contributor: Jeff Bindel via
LaptopsPlural. Not a vulnerability PoC.Test plan