Skip to content

remove to_rbfe_alchemical_network - #819

Merged
atravitz merged 1 commit into
mainfrom
maint/remove_to_rbfe_alchemical_network
Aug 5, 2026
Merged

remove to_rbfe_alchemical_network#819
atravitz merged 1 commit into
mainfrom
maint/remove_to_rbfe_alchemical_network

Conversation

@atravitz

@atravitz atravitz commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

in v1.12, we announced this would be released in v1.13 - that's now!

Tips

  • Comment "pre-commit.ci autofix" to have pre-commit.ci atomically format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

LLM / AI generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
If yes, please provide details here:

Checklist

  • Added a news entry
  • Filled in the AI-generated code disclosure.

Developers certificate of origin

@atravitz
atravitz marked this pull request as ready for review August 3, 2026 22:15
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (46a3977) to head (8822582).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
- Coverage   98.65%   98.64%   -0.02%     
==========================================
  Files          43       43              
  Lines        2825     2797      -28     
==========================================
- Hits         2787     2759      -28     
  Misses         38       38              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz
atravitz force-pushed the maint/remove_to_rbfe_alchemical_network branch from 085c5a8 to 8822582 Compare August 3, 2026 22:18
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🚨 API breaking changes detected! 🚨

View workflow run

Griffe output
$ griffe check "gufe" -s src --no-inspection --no-color --verbose -a origin/main
src/gufe/ligandnetwork.py:0: LigandNetwork.to_rbfe_alchemical_network:
Public object was removed

src/gufe/tests/test_ligand_network.py:0: TestLigandNetwork.test_to_rbfe_alchemical_network:
Public object was removed

src/gufe/tests/test_ligand_network.py:0: TestLigandNetwork.test_to_rbfe_alchemical_network_autoname_false:
Public object was removed

src/gufe/tests/test_ligand_network.py:0: TestLigandNetwork.test_to_rbfe_alchemical_network_autoname_true:
Public object was removed

src/gufe/tests/test_ligand_network.py:0: TestLigandNetwork.test_to_rhfe_alchemical_network:
Public object was removed


@atravitz

atravitz commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

re: griffe failure - this is the api break we are doing intentionally.

@IAlibay IAlibay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - we'll need to remove / fix some of the cookbook docs too. For example, the create_alchemical_network cookbook uses this API point.

@atravitz

atravitz commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

This looks good - we'll need to remove / fix some of the cookbook docs too. For example, the create_alchemical_network cookbook uses this API point.

yes! tracked here OpenFreeEnergy/ExampleNotebooks#291

@atravitz atravitz added this to the v1.13.0 milestone Aug 4, 2026
@atravitz
atravitz merged commit bf28129 into main Aug 5, 2026
11 of 12 checks passed
@atravitz
atravitz deleted the maint/remove_to_rbfe_alchemical_network branch August 5, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants