remove to_rbfe_alchemical_network - #819
Merged
Merged
Conversation
atravitz
marked this pull request as ready for review
August 3, 2026 22:15
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
- Coverage 98.65% 98.64% -0.02%
==========================================
Files 43 43
Lines 2825 2797 -28
==========================================
- Hits 2787 2759 -28
Misses 38 38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
atravitz
force-pushed
the
maint/remove_to_rbfe_alchemical_network
branch
from
August 3, 2026 22:18
085c5a8 to
8822582
Compare
|
🚨 API breaking changes detected! 🚨 Griffe output |
Contributor
Author
|
re: griffe failure - this is the api break we are doing intentionally. |
IAlibay
reviewed
Aug 4, 2026
IAlibay
left a comment
Member
There was a problem hiding this comment.
This looks good - we'll need to remove / fix some of the cookbook docs too. For example, the create_alchemical_network cookbook uses this API point.
IAlibay
approved these changes
Aug 4, 2026
Contributor
Author
yes! tracked here OpenFreeEnergy/ExampleNotebooks#291 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in v1.12, we announced this would be released in v1.13 - that's now!
Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
If yes, please provide details here:
Checklist
newsentryDevelopers certificate of origin