feat(model): a workspace copy rooted at a library's packages is the library

[devin-ai-integration]

What and why

The language server treated a workspace copy of a bundled library file as the user's document — derived ids, a minting code action on every declaration — where sysml -convert recognised the same bytes as the library. The workspace now applies the one recognition, so a copy rooted at a library's packages is the library in the editor as it is on the CLI.

• Shared recognition. The roots-based recogniser moves from internal/core/export to internal/core/identity (LibraryRoot, Catalog.DocumentRootedAt, Catalog.NamesEveryRoot, LibraryVersion); export/library_names.go delegates to it and RDF behaviour is unchanged. A document qualifies when every root is a top-level package of one bundled library file that either states that package's normative id or is declared as the library declares it (library/standard keywords). Nested library elements, a foreign root id, or roots from different bundled files do not qualify.
• Workspace stand-in lifecycle (model/library_version.go, workspace.go): a qualifying document displaces the bundled file from the overlay index, is marked with the bundled tier and its own digest, and its declarations are what the library's names resolve to. IdentityOf answers normative identity for it (and, via resolverOver(w.libBase), still for a displaced bundled file). Editing a root so it stops qualifying, closing a version whose on-disk text is the user's, or removing it restores the bundled file; several copies may coexist, and the sibling index used by ApplyEdit mirrors the arrangement.
• A file opened under a bundled file's own name now restores that file on close. Before, Close removed the document and put nothing back, so every later document was checked against a library missing it. TestExprTypeCheckNoStdlibFalsePositives passed on develop only because of this: with the whole library present, the checker reports nine dimension defects in the published SI.sysml and USCustomaryUnits.sysml (e.g. 'Sv/s' : DoseEquivalentUnit, J*s*eV*s : TotalAngularMomentumUnit, 229835/900 [K]). Each is verified against the ISQ definitions and recorded in docs/project/omg-issues.md ("Defects in the vendored quantity libraries"); the gate pins them as an exact set — an extra finding fails as a false positive, a missing one as a regression — and TestExprTypeCheckStdlibFindingsNeedTheLibrary proves the library survives the close. Library bytes are untouched.

internal/interop/reposync/diff.go was inspected and needs no change: it does not consume the workspace-vs-library classification.

Specification basis

No specification clause moves; this is editor/CLI consistency over the project's own normative-identity rules (docs/reference/rdf-mapping.md, now naming the shared recognition for both surfaces). The nine library findings rest on SysML v2.0 §9.8.9.1 (dimension of a bound value) and, for 229835/900 [K], KerML 1.0 §8.2.5.8.1–8.2.5.8.2 (the bracket construction is a primary expression), the same reading already adjudicated for the geometry example.

How it was verified

• New: internal/core/model/library_version_test.go (qualifying copy stands in, normative identity, no library-package or duplicate-name diagnostics, multiple copies, root rename / keyword drop / foreign id stop qualification, normative explicit id qualifies without keywords, close follows on-disk text, delete releases, nested-only / mixed / cross-file roots do not qualify, ApplyEdit through a standing copy, the exact-bundled-name case); identity/pilot_library_xmi_test.go covers DocumentRootedAt; internal/lsp/identity_test.go and hover_test.go expect (normative, KerML) hover and no mint action on a qualifying copy, and mint on a non-qualifying user file.
• go build ./..., go vet ./..., gofmt -l . (empty), go test -count=1 ./..., make lint — all green.
• OPENSYSML_REQUIRE_TRAINING_CORPUS=1 OPENSYSML_REQUIRE_PILOT_CORPORA=1 go test -count=1 ./internal/core/model -run 'TestTrainingExamples|TestPilotCorpora' and ./internal/core/export -run TestCorpusRoundTrip — green, no ratchet movement.
• python3 scripts/changelog.py check, scripts/check-doc-ids.py, scripts/check-doc-links.py, make docs-counts — green (test counts regenerated).

Checklist

• make test and make lint pass locally
• Tests added or updated for the change
• Documentation extended where it already covers the surface (see CONTRIBUTING.md)
• Changelog entry added as changes/unreleased/<slug>.<section>.md, not as an edit to CHANGELOG.md
• baselines regenerated and make docs-counts run if a gate count moved (compliance rows need nothing: the census is counted at docs build)
• No internal work-item labels (waves, slices, F4, K5) in the body, docs, or changelog

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring