Multiple crops example

[mzient]

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

Implements a pipeline example requested by a user in #1579

Additional information:

Affected modules and functionalities:

N/A

Key points relevant for the review:

Tests:

• Existing tests apply
• New tests added
  • Python tests
  • GTests
  • Benchmark
  • Other
• N/A

Checklist

Documentation

• Existing documentation applies
• Documentation updated
  • Docstring
  • Doxygen
  • RST
  • Jupyter
  • Other
• N/A

DALI team only

Requirements

• Implements new requirements
• Affects existing requirements
• N/A

REQ IDs: N/A

JIRA TASK: N/A

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[dali-automaton]

CI MESSAGE: [18958041]: BUILD STARTED

[dali-automaton]

CI MESSAGE: [18958465]: BUILD STARTED

[dali-automaton]

CI MESSAGE: [18958465]: BUILD PASSED

[stiepan]

For the future, I belive we could make the resize and crop ops support similar trick, likely in a bit more straightforward way.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

szkarpinski commented on 2024-10-04T11:44:12Z
----------------------------------------------------------------

Line #42.        )  # convert to float and mark outermost dimension as"frame"

Nitpicks: Why +0.0 and not cast? Also, there's a missing space before "frame"

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

szkarpinski commented on 2024-10-04T11:44:13Z
----------------------------------------------------------------

How about adding a sentence explaining what the images above mean? The first single image was confusing to me - I expected sequences of equal length. It took me some time to notice num_crops = random (...) in the code.

mzient commented on 2024-11-04T11:46:51Z
----------------------------------------------------------------

Yeah, I'd recommend playing with the seed a bit to get an example with three different sequence lengths, preferably without a single-image sequence.

[mzient]

Yeah, I'd recommend playing with the seed a bit to get an example with three different sequence lengths, preferably without a single-image sequence.

---

View entire conversation on ReviewNB

[greptile-apps]

Greptile Summary

The PR adds and indexes a Jupyter example demonstrating how to produce multiple fixed-size or resized crops from each input image.

• Adds equal-sized cropping with per-frame affine transforms.
• Adds variable-sized crops fused with resizing.
• Registers the notebook under the image-processing examples and relevant operator references.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
docs/examples/image_processing/index.py	Registers the new multiple-crops notebook and links it from the relevant operator references.
docs/examples/image_processing/multiple_crops.ipynb	Adds executable fixed-size and variable-size multiple-crop pipeline examples.

_{Reviews (3): Last reviewed commit: "Update the example." | Re-trigger Greptile}

[greptile-apps]

Additional Comments (2)

1. docs/examples/image_processing/multiple_crops.ipynb, line 1 (link)

   style: Typo: "diplay" should be "display"

2. docs/examples/image_processing/multiple_crops.ipynb, line 26-27 (link)

   style: Unused imports: matplotlib.patches as patches and math are imported but never used in the notebook.

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[dali-automaton]

CI MESSAGE: [65036486]: BUILD STARTED

[dali-automaton]

CI MESSAGE: [65036486]: BUILD FAILED

[dali-automaton]

CI MESSAGE: [65036486]: BUILD PASSED

[dali-automaton]

CI MESSAGE: [66747938]: BUILD STARTED