Skip to content

Refactor/translatable content - #540

Merged
jliermann merged 6 commits into
localisationfrom
refactor/translatable-content
Sep 4, 2026
Merged

Refactor/translatable content#540
jliermann merged 6 commits into
localisationfrom
refactor/translatable-content

Conversation

@jliermann

Copy link
Copy Markdown
Contributor

This pull request introduces several improvements focused on code reuse, maintainability, and test performance. The main changes include centralizing feature button configuration, refactoring tests for efficiency, and adjusting test parallelism for CI environments.

Centralization and Reuse:

  • Introduced a new commonFeatures module to centralize configuration for commonly used feature buttons, reducing duplication and making it easier to update feature button properties across the documentation.
  • Refactored multiple documentation files (00_intro.mdx, 00_data_guide.mdx, 00_smartlab.mdx, 00_lbe_intro.mdx) to use the new commonFeatures object for rendering FeatureButton components, ensuring consistency and simplifying future updates. [1] [2] [3] [4] [5] [6] [7] [8]

Testing Improvements:

  • Refactored the Playwright visual regression test (visual-pages.spec.ts) to use synchronous file system methods (readFileSync, readdirSync) instead of asynchronous ones, simplifying the test code and improving reliability. [1] [2] [3] [4] [5]
  • Changed the test structure to discover all routes up front and run visual regression tests in parallel using Playwright's test.describe.configure({ mode: "parallel" }), which speeds up test execution.

CI Performance:

  • Updated the Playwright configuration to set the number of workers based on the environment: 2 workers for CI, 4 for local development, optimizing resource usage and test speed.

These changes collectively improve maintainability, consistency, and test performance across the codebase.

@jliermann
jliermann merged commit 695cee0 into localisation Sep 4, 2026
3 checks passed
@jliermann
jliermann deleted the refactor/translatable-content branch September 4, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant