fix(githubcoverage): keep App coverage honest about user-token union - #122
Merged
Conversation
Local identities without a GitHub id were dropped, and unknown reconciler statuses leaked into the report. Record user_token_union as not-proven instead of implying a PAT membership union. Signed-off-by: rldyourmnd <danil@nddev.it.com> Co-authored-by: Cursor <cursoragent@cursor.com>
core/app tests are inside the source-tree digest. Signed-off-by: rldyourmnd <danil@nddev.it.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_token_union: not-proveninstead of looking like a PAT membership union.provider_id <= 0stayunknownwithgithub_id_missing; they are not dropped and do not collapse on id 0.unknown, not raw reconciler vocabulary.--include-localon an empty root is proven at the app layer.Test plan
go test ./core/githubcoverage ./core/app ./core/cli -count=1gds generate repository --checkon the restamped HEAD