Gate ZipArchive benchmarks in the project file - #6
Closed
LoopedBard3 wants to merge 2 commits into
Closed
LoopedBard3 wants to merge 2 commits into
LoopedBard3 wants to merge 2 commits into
Conversation
Add sync and async ZipArchive metadata-reading benchmarks over memory and file streams. Move the runtime-async feature gate to the repository root so BenchmarkDotNet-generated projects inherit it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6957835-b7f3-45ee-875f-4efad68e3c4e
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to dotnet#5303, intended to target agocke/performance's
runtime-async-ziparchivebranch.Moves the whole-file .NET 10 framework gate from
ZipArchive.csintoMicroBenchmarks.csproj, matching the existing project-level exclusions (includingZstandard.csin the same directory). Benchmark code and supported target frameworks are unchanged.Validation: evaluated the exact exclusion ItemGroup with installed MSBuild: excluded on net462/net8.0/net9.0, included on net10.0/net11.0. Full project evaluation was blocked because the pinned .NET 11 preview SDK is not installed.