test: cover from_processor with a stratigraphic column - #297
Open
manduinca wants to merge 1 commit into
Open
Conversation
from_processor had no test coverage. The path broke when set_stratigraphic_column raised DeprecationWarning unconditionally (Loop3D#296) and nothing caught it. The raise is gone in master since Loop3D#300, so this regression test passes and guards the path from now on.
manduinca
changed the title
manduinca
force-pushed
the
fix/set-stratigraphic-column-warn
branch
from
September 2, 2026 16:00
60fccbc to
31774ce
Compare
Contributor
Author
|
Rebased on master. The fix landed in the meantime through #300, so I dropped it and kept only the regression test. It still seems worth having: nothing in the test suite exercises The failures in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #296
GeologicalModel.from_processorhad no test coverage: whenset_stratigraphic_columnraisedDeprecationWarningunconditionally (#296) nothing in the suite caught it. The fix for that has since landed through #300, so this PR is reduced to the regression test.The test builds a small synthetic processor and asserts
from_processorcompletes and populates the stratigraphic column. It passes against current master.