refactor(engine): drop 21 re-export shims - #317
Merged
Merged
Conversation
Remove all engine re-export shims except safety_reexports.go (which has 217 external references and is a separate migration). Callers now import the sub-package directly (e.g. planning.PlannedCall, cost.Cost, token.EstimateTokens) instead of going through the engine namespace. Verified: go build ./..., go vet, golangci-lint (0 issues), full go test ./..., make boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 21 of the 22 remaining
internal/engine/*_reexports.goshims (the earlier PR removedplanning). Callers now import the sub-package directly instead of going through the flattenedenginenamespace.Examples:
engine.PlannedCall→planning.PlannedCall,engine.Cost→cost.Cost,engine.EstimateTokens→token.EstimateTokens,engine.NewFewShotStore→scaffold.NewFewShotStore.The last shim,
safety_reexports.go, has 217 external references across 32 files and is left for a separate PR.Verified:
go build ./...,go vet,golangci-lint(0 issues), fullgo test ./...,make boundaries.