refactor(engine): drop planning re-export shim - #316
Merged
Merged
Conversation
Remove internal/engine/planning_reexports.go and qualify the six call sites in tool_service.go with the planning package directly. First of the 23 engine re-export shims to go; the plan doc frames this as incremental multi-PR work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the 23
internal/engine/*_reexports.goshims to be removed (the repo's owndocs/plans/engine-refactor-plan.mdframes this as incremental multi-PR work).Removes
planning_reexports.goand qualifies the six call sites intool_service.gowith theplanningpackage directly. No external package referencedengine.<planning symbol>(verified), so this is an internal-only cleanup.Verified:
go build ./...,go vet,golangci-lint,go test ./internal/engine/...,make boundaries.Note: I attempted to remove all 22 remaining shims at once and the compiler surfaced only ~10 undefined symbols initially, but the automated qualification cascaded (const blocks, package-name collisions) and corrupted files, so I reverted to this single verified shim. The rest should be done one at a time.