refactor(tool): extract safety helpers into internal/toolsafety - #315
Merged
Merged
Conversation
Move the self-contained safety layer (destructive-command detection, credential detection, binary detection, output truncation, SSRF guards, command segmentation) out of the 41k-LOC internal/tool package into a new low-level internal/toolsafety package. tool re-exports the symbols so existing callers keep compiling, and internal/engine/search now imports toolsafety directly instead of the god package. internal/tool loses ~500 lines of implementation and ~660 lines of tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First cut of the
internal/toolgod-package split.Moves the self-contained safety layer out of the 41k-LOC
internal/toolpackage into a new low-levelinternal/toolsafety:ValidateURLPublic,SSRFSafeClient,WithSSRFSkip)SegmentCommand)toolre-exports the symbols so existing callers keep compiling, andinternal/engine/searchnow importstoolsafetydirectly instead of the god package — a real decoupling, not just a re-export.internal/toolloses ~500 lines of implementation and ~660 lines of tests.Verified:
go vet,golangci-lint(0 issues), fullgo test ./...,make boundaries, gofumpt clean.